aboutsummaryrefslogtreecommitdiff
path: root/mk/config.mk
diff options
context:
space:
mode:
authorJerome Forissier <jerome.forissier@linaro.org>2017-10-12 10:11:45 +0200
committerJérôme Forissier <jerome.forissier@linaro.org>2017-10-12 10:59:49 +0200
commit7411e0e1ebd42a8c649bdfb2e7dbf9958caf7af9 (patch)
tree6763340510cba0d8051439e85558c7cc28fe0e99 /mk/config.mk
parent3ff067c414d6b3039c6f4edaf9fc8972fadf62d2 (diff)
Add comment about CFG_UNWIND
Update the comment in the main configuration file to state that CFG_UNWIND should be disabled in production builds. Signed-off-by: Jerome Forissier <jerome.forissier@linaro.org> Suggested-by: Etienne Carriere <etienne.carriere@linaro.org> Reviewed-by: Etienne Carriere <etienne.carriere@linaro.org> Reviewed-by: Jens Wiklander <jens.wiklander@linaro.org>
Diffstat (limited to 'mk/config.mk')
-rw-r--r--mk/config.mk6
1 files changed, 5 insertions, 1 deletions
diff --git a/mk/config.mk b/mk/config.mk
index 6038db7e..25625d72 100644
--- a/mk/config.mk
+++ b/mk/config.mk
@@ -152,13 +152,17 @@ CFG_LIBUTILS_WITH_ISOC ?= y
# With CFG_TA_FLOAT_SUPPORT enabled TA code is free use floating point types
CFG_TA_FLOAT_SUPPORT ?= y
-# Stack unwinding: print a stack dump to the console on abort
+# Stack unwinding: print a stack dump to the console on core or TA abort, or
+# when a TA panics.
# If CFG_UNWIND is enabled, both the kernel and user mode call stacks can be
# unwound (not paged TAs, however).
# Note that 32-bit ARM code needs unwind tables for this to work, so enabling
# this option will increase the size of the 32-bit TEE binary by a few KB.
# Similarly, TAs have to be compiled with -funwind-tables (default when the
# option is set) otherwise they can't be unwound.
+# Warning: since the unwind sequence for user-mode (TA) code is implemented in
+# the privileged layer of OP-TEE, enabling this feature will weaken the
+# user/kernel isolation. Therefore it should be disabled in release builds.
ifeq ($(CFG_TEE_CORE_DEBUG),y)
CFG_UNWIND ?= y
endif