summaryrefslogtreecommitdiff
path: root/libiberty/ChangeLog
diff options
context:
space:
mode:
authorTom Tromey <tom@tromey.com>2019-01-21 15:25:29 +0000
committerTom Tromey <tromey@gcc.gnu.org>2019-01-21 15:25:29 +0000
commit2197ea1791698761983e0b8a7b3d6d2b50f87d1f (patch)
treeeecff65f98f1b03858f03fdc3b8165fba939c075 /libiberty/ChangeLog
parentc73e7656f5f64a8ee544270adea13cc39ddae70d (diff)
Fix leak in splay-tree
Philippe Waroquiers noticed a memory leak in gdb, which he tracked down to a bug in splay-tree. splay_tree_remove does not call the `delete_key' function when it removes the old node; but it should. I looked at every splay tree in GCC and there is only one that passes a non-NULL delete function -- the one in lto.c. That file does not call splay_tree_remove. So, I think this is safe to check in. I re-ran the LTO tests to double check. libiberty/ * splay-tree.c (splay_tree_remove): Delete the key if necessary. From-SVN: r268116
Diffstat (limited to 'libiberty/ChangeLog')
-rw-r--r--libiberty/ChangeLog4
1 files changed, 4 insertions, 0 deletions
diff --git a/libiberty/ChangeLog b/libiberty/ChangeLog
index bcc0227bdd8..08d0a436cf2 100644
--- a/libiberty/ChangeLog
+++ b/libiberty/ChangeLog
@@ -1,3 +1,7 @@
+2019-01-21 Tom Tromey <tom@tromey.com>
+
+ * splay-tree.c (splay_tree_remove): Delete the key if necessary.
+
2019-01-14 Tom Honermann <tom@honermann.net>
* cp-demangle.c (cplus_demangle_builtin_types)