summaryrefslogtreecommitdiff
path: root/libgo/runtime
diff options
context:
space:
mode:
authorIan Lance Taylor <ian@gcc.gnu.org>2019-05-01 21:34:16 +0000
committerIan Lance Taylor <ian@gcc.gnu.org>2019-05-01 21:34:16 +0000
commit5e87c2806ff4e9057c4c46fa1d9c8ac91ce3dae9 (patch)
treee3583babaa67131fcef04311cf265c9415582ca9 /libgo/runtime
parent1da37f43b21e0c35e57b627edfa99ec80d2976ee (diff)
compiler,runtime: do more direct interfaces
A direct interface is an interface whose data word contains the actual data value, instead of a pointer to it. The gc toolchain creates a direct interface if the value is pointer shaped, that includes pointers (including unsafe.Pointer), functions, channels, maps, and structs and arrays containing a single pointer-shaped field. In gccgo, we only do this for pointers. This CL unifies direct interface types with gc. This reduces allocations when converting such types to interfaces. Our method functions used to always take pointer receivers, to make interface calls easy. Now for direct interface types, their value methods will take value receivers. For a pointer to those types, when converted to interface, the interface data contains the pointer. For that interface to call a value method, it will need a wrapper method that dereference the pointer and invokes the value method. The wrapper method, instead of the actual one, is put into the itable of the pointer type. In the runtime, adjust funcPC for the new layout of interfaces of functions. Reviewed-on: https://go-review.googlesource.com/c/gofrontend/+/168409 From-SVN: r270779
Diffstat (limited to 'libgo/runtime')
-rw-r--r--libgo/runtime/go-callers.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/libgo/runtime/go-callers.c b/libgo/runtime/go-callers.c
index a72b4e85454..31ff4747b98 100644
--- a/libgo/runtime/go-callers.c
+++ b/libgo/runtime/go-callers.c
@@ -75,7 +75,7 @@ callback (void *data, uintptr_t pc, const char *filename, int lineno,
return 0;
if (p - function > 3 && __builtin_strcmp (p - 3, "..r") == 0)
return 0;
- if (p - function > 6 && __builtin_strcmp (p - 6, "..stub") == 0)
+ if (p - function > 6 && __builtin_strncmp (p - 6, "..stub", 6) == 0)
return 0;
}