diff options
author | Ian Lance Taylor <iant@golang.org> | 2020-01-02 15:05:27 -0800 |
---|---|---|
committer | Ian Lance Taylor <iant@golang.org> | 2020-01-21 23:53:22 -0800 |
commit | 5a8ea165926cb0737ab03bc48c18dc5198ab5305 (patch) | |
tree | 962dc3357c57f019f85658f99e2e753e30201c27 /libgo/go/syscall/syscall_linux_test.go | |
parent | 6ac6529e155c9baa0aaaed7aca06bd38ebda5b43 (diff) |
libgo: update to Go1.14beta1
Reviewed-on: https://go-review.googlesource.com/c/gofrontend/+/214297
Diffstat (limited to 'libgo/go/syscall/syscall_linux_test.go')
-rw-r--r-- | libgo/go/syscall/syscall_linux_test.go | 11 |
1 files changed, 10 insertions, 1 deletions
diff --git a/libgo/go/syscall/syscall_linux_test.go b/libgo/go/syscall/syscall_linux_test.go index 2ad236573e4..97059c87d3d 100644 --- a/libgo/go/syscall/syscall_linux_test.go +++ b/libgo/go/syscall/syscall_linux_test.go @@ -299,6 +299,14 @@ func TestSyscallNoError(t *testing.T) { t.Skip("skipping on non-32bit architecture") } + // See https://golang.org/issue/35422 + // On MIPS, Linux returns whether the syscall had an error in a separate + // register (R7), not using a negative return value as on other + // architectures. + if runtime.GOARCH == "mips" || runtime.GOARCH == "mipsle" { + t.Skipf("skipping on %s", runtime.GOARCH) + } + if os.Getuid() != 0 { t.Skip("skipping root only test") } @@ -367,7 +375,8 @@ func TestSyscallNoError(t *testing.T) { if filesystemIsNoSUID(tmpBinary) { t.Skip("skipping test when temp dir is mounted nosuid") } - t.Errorf("expected %s, got %s", want, got) + // formatted so the values are aligned for easier comparison + t.Errorf("expected %s,\ngot %s", want, got) } } |