diff options
| author | Martin Sebor <msebor@redhat.com> | 2019-12-05 01:28:11 +0000 |
|---|---|---|
| committer | Martin Sebor <msebor@gcc.gnu.org> | 2019-12-04 18:28:11 -0700 |
| commit | 268209f3a0dc07fcf13534610447ab732742eb2f (patch) | |
| tree | 19c70c9ade74615720a40b206b35dcfc02c63f53 /gcc/tree-ssa-strlen.c | |
| parent | a59c50bd14f5bcb467a21ceb55f6b082510efc2f (diff) | |
PR middle-end/91582 - missing heap overflow detection for strcpy
gcc/ChangeLog:
PR middle-end/91582
* builtins.c (gimple_call_alloc_size): New function.
(compute_objsize): Add argument. Call gimple_call_alloc_size.
Handle variable offsets and indices.
* builtins.h (gimple_call_alloc_size): Declare.
(compute_objsize): Add argument.
* gcc/gimple-ssa-warn-restrict.c: Remove assertions.
* tree-ssa-strlen.c (handle_store): Handle calls to allocated objects.
gcc/testsuite/ChangeLog:
PR middle-end/91582
* c-c++-common/Wstringop-truncation.c: Remove xfails.
* g++.dg/warn/Wstringop-overflow-4.C: New test.
* g++.dg/ext/attr-alloc_size.C: Suppress -Warray-bounds.
* gcc.dg/Warray-bounds-56.c: New test.
* gcc.dg/Wstringop-overflow-22.c: New test.
* gcc.dg/attr-alloc_size.c: Suppress -Warray-bounds.
* gcc.dg/attr-copy-2.c: Same.
* gcc.dg/builtin-stringop-chk-5.c: Remove xfails.
* gcc.dg/builtin-stringop-chk-8.c: Same. Correct the text of expected
warnings.
* gcc.target/i386/pr82002-2a.c: Prune expected warning.
* gcc.target/i386/pr82002-2b.c: Same.
From-SVN: r278983
Diffstat (limited to 'gcc/tree-ssa-strlen.c')
| -rw-r--r-- | gcc/tree-ssa-strlen.c | 18 |
1 files changed, 16 insertions, 2 deletions
diff --git a/gcc/tree-ssa-strlen.c b/gcc/tree-ssa-strlen.c index d46586a90e5..beff17b37f1 100644 --- a/gcc/tree-ssa-strlen.c +++ b/gcc/tree-ssa-strlen.c @@ -4394,8 +4394,22 @@ handle_store (gimple_stmt_iterator *gsi, bool *zero_write, const vr_values *rval stmt, lenrange[2], dstsize)) { if (decl) - inform (DECL_SOURCE_LOCATION (decl), - "destination object declared here"); + { + if (TREE_CODE (decl) == SSA_NAME) + { + gimple *stmt = SSA_NAME_DEF_STMT (decl); + if (is_gimple_call (stmt)) + { + tree allocfn = gimple_call_fndecl (stmt); + inform (gimple_location (stmt), + "destination region allocated by %qD " + "here", allocfn); + } + } + else + inform (DECL_SOURCE_LOCATION (decl), + "destination object declared here"); + } gimple_set_no_warning (stmt, true); } } |