summaryrefslogtreecommitdiff
path: root/env
diff options
context:
space:
mode:
authorTom Rini <trini@konsulko.com>2022-07-23 13:05:03 -0400
committerTom Rini <trini@konsulko.com>2022-08-04 16:18:47 -0400
commit17ead040d402c6e1fe26ac5acc4773146c8a0918 (patch)
tree9bfa97577dc86a0947a2d07b455dbd6b0638ed21 /env
parent1d3ecdac7ecd5d9b237067b0c96aa1e618c8621d (diff)
Audit <flash.h> inclusion
A large number of files include <flash.h> as it used to be how various SPI flash related functions were found, or for other reasons entirely. In order to migrate some further CONFIG symbols to Kconfig we need to not include flash.h in cases where we don't have a NOR flash of some sort enabled. Furthermore, in cases where we are in common code and it doesn't make sense to try and further refactor the code itself in to new files we need to guard this inclusion. Signed-off-by: Tom Rini <trini@konsulko.com>
Diffstat (limited to 'env')
-rw-r--r--env/flash.c2
-rw-r--r--env/sf.c1
2 files changed, 1 insertions, 2 deletions
diff --git a/env/flash.c b/env/flash.c
index 9c8abfa016..1e75f8c004 100644
--- a/env/flash.c
+++ b/env/flash.c
@@ -13,7 +13,6 @@
#include <command.h>
#include <env.h>
#include <env_internal.h>
-#include <flash.h>
#include <log.h>
#include <asm/global_data.h>
#include <linux/stddef.h>
@@ -26,6 +25,7 @@ DECLARE_GLOBAL_DATA_PTR;
#ifndef CONFIG_SPL_BUILD
# if defined(CONFIG_CMD_SAVEENV) && defined(CONFIG_CMD_FLASH)
+# include <flash.h>
# define CMD_SAVEENV
# elif defined(CONFIG_ENV_ADDR_REDUND)
# error CONFIG_ENV_ADDR_REDUND must have CONFIG_CMD_SAVEENV & CONFIG_CMD_FLASH
diff --git a/env/sf.c b/env/sf.c
index 4b768542c1..a425ecc11c 100644
--- a/env/sf.c
+++ b/env/sf.c
@@ -12,7 +12,6 @@
#include <dm.h>
#include <env.h>
#include <env_internal.h>
-#include <flash.h>
#include <malloc.h>
#include <spi.h>
#include <spi_flash.h>