diff options
| author | Linus Torvalds <torvalds@linux-foundation.org> | 2017-04-02 17:10:08 -0700 |
|---|---|---|
| committer | Sasha Levin <alexander.levin@microsoft.com> | 2018-03-04 10:28:23 -0500 |
| commit | 96f984040a3d93b2b083d4c45765d421c5203cad (patch) | |
| tree | f84a194f3e50fd98e485c393a59dec537ce9c447 /fs | |
| parent | f7a709f6557e43078bcf96ca230407d8dbe5dd02 (diff) | |
vfs: don't do RCU lookup of empty pathnames
[ Upstream commit c0eb027e5aef70b71e5a38ee3e264dc0b497f343 ]
Normal pathname lookup doesn't allow empty pathnames, but using
AT_EMPTY_PATH (with name_to_handle_at() or fstatat(), for example) you
can trigger an empty pathname lookup.
And not only is the RCU lookup in that case entirely unnecessary
(because we'll obviously immediately finalize the end result), it is
actively wrong.
Why? An empth path is a special case that will return the original
'dirfd' dentry - and that dentry may not actually be RCU-free'd,
resulting in a potential use-after-free if we were to initialize the
path lazily under the RCU read lock and depend on complete_walk()
finalizing the dentry.
Found by syzkaller and KASAN.
Reported-by: Dmitry Vyukov <dvyukov@google.com>
Reported-by: Vegard Nossum <vegard.nossum@gmail.com>
Acked-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
Diffstat (limited to 'fs')
| -rw-r--r-- | fs/namei.c | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/fs/namei.c b/fs/namei.c index c7a6eabc02a5..0d97235019a9 100644 --- a/fs/namei.c +++ b/fs/namei.c @@ -1894,6 +1894,9 @@ static int path_init(int dfd, const struct filename *name, unsigned int flags, int retval = 0; const char *s = name->name; + if (!*s) + flags &= ~LOOKUP_RCU; + nd->last_type = LAST_ROOT; /* if there are only slashes... */ nd->flags = flags | LOOKUP_JUMPED | LOOKUP_PARENT; nd->depth = 0; |