diff options
| author | Nikolay Borisov <nborisov@suse.com> | 2017-12-05 09:29:19 +0200 |
|---|---|---|
| committer | Sasha Levin <alexander.levin@microsoft.com> | 2018-03-04 10:28:22 -0500 |
| commit | 789d8f6ea2adfed1f4c1df6a12047d9c80ed9f35 (patch) | |
| tree | 6243905dabbaea71015181c230e146db896ad5db /fs | |
| parent | 996b7d3177b9860c80d903a650fa803e22f8d35e (diff) | |
btrfs: Handle btrfs_set_extent_delalloc failure in fixup worker
[ Upstream commit f3038ee3a3f1017a1cbe9907e31fa12d366c5dcb ]
This function was introduced by 247e743cbe6e ("Btrfs: Use async helpers
to deal with pages that have been improperly dirtied") and it didn't do
any error handling then. This function might very well fail in ENOMEM
situation, yet it's not handled, this could lead to inconsistent state.
So let's handle the failure by setting the mapping error bit.
Cc: stable@vger.kernel.org
Signed-off-by: Nikolay Borisov <nborisov@suse.com>
Reviewed-by: Qu Wenruo <wqu@suse.com>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
Diffstat (limited to 'fs')
| -rw-r--r-- | fs/btrfs/inode.c | 10 |
1 files changed, 9 insertions, 1 deletions
diff --git a/fs/btrfs/inode.c b/fs/btrfs/inode.c index d14af5bd13d6..1423231c7e49 100644 --- a/fs/btrfs/inode.c +++ b/fs/btrfs/inode.c @@ -1999,7 +1999,15 @@ again: goto out; } - btrfs_set_extent_delalloc(inode, page_start, page_end, &cached_state); + ret = btrfs_set_extent_delalloc(inode, page_start, page_end, + &cached_state); + if (ret) { + mapping_set_error(page->mapping, ret); + end_extent_writepage(page, ret, page_start, page_end); + ClearPageChecked(page); + goto out; + } + ClearPageChecked(page); set_page_dirty(page); out: |