diff options
| author | Mike Snitzer <snitzer@redhat.com> | 2017-06-20 19:14:30 -0400 |
|---|---|---|
| committer | Sasha Levin <alexander.levin@microsoft.com> | 2018-03-20 23:49:49 -0400 |
| commit | f3c22cc3eaf1534d0aa8ec2ed8d3ddde413930ae (patch) | |
| tree | b3ffe0a4d81d2e07a903e187ac798de5ea48a998 /drivers | |
| parent | b434e837642049c96cf56c730279f410d520b33b (diff) | |
dm io: fix duplicate bio completion due to missing ref count
[ Upstream commit feb7695fe9fb83084aa29de0094774f4c9d4c9fc ]
If only a subset of the devices associated with multiple regions support
a given special operation (eg. DISCARD) then the dec_count() that is
used to set error for the region must increment the io->count.
Otherwise, when the dec_count() is called it can cause the dm-io
caller's bio to be completed multiple times. As was reported against
the dm-mirror target that had mirror legs with a mix of discard
capabilities.
Bug: https://bugzilla.kernel.org/show_bug.cgi?id=196077
Reported-by: Zhang Yi <yizhan@redhat.com>
Signed-off-by: Mike Snitzer <snitzer@redhat.com>
Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
Diffstat (limited to 'drivers')
| -rw-r--r-- | drivers/md/dm-io.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/md/dm-io.c b/drivers/md/dm-io.c index 74adcd2c967e..01d7b5785b8e 100644 --- a/drivers/md/dm-io.c +++ b/drivers/md/dm-io.c @@ -299,6 +299,7 @@ static void do_region(int rw, unsigned region, struct dm_io_region *where, else if (rw & REQ_WRITE_SAME) special_cmd_max_sectors = q->limits.max_write_same_sectors; if ((rw & (REQ_DISCARD | REQ_WRITE_SAME)) && special_cmd_max_sectors == 0) { + atomic_inc(&io->count); dec_count(io, region, -EOPNOTSUPP); return; } |