diff options
| author | David Howells <dhowells@redhat.com> | 2016-09-04 13:10:10 +0100 |
|---|---|---|
| committer | David Howells <dhowells@redhat.com> | 2016-09-04 13:10:10 +0100 |
| commit | af338a9ea60acc6337fe9fcdcf664aec2520e541 (patch) | |
| tree | 5d7883b1d7cee050b782c540b7cee933adb12dd5 /net/rxrpc/call_object.c | |
| parent | 00b5407e427ac2588a2496b92035a94602b3cd1b (diff) | |
rxrpc: The client call state must be changed before attachment to conn
We must set the client call state to RXRPC_CALL_CLIENT_SEND_REQUEST before
attaching the call to the connection struct, not after, as it's liable to
receive errors and conn aborts as soon as the assignment is made - and
these will cause its state to be changed outside of the initiating thread's
control.
Signed-off-by: David Howells <dhowells@redhat.com>
Diffstat (limited to 'net/rxrpc/call_object.c')
| -rw-r--r-- | net/rxrpc/call_object.c | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/net/rxrpc/call_object.c b/net/rxrpc/call_object.c index 57e00fc9cff2..65691742199b 100644 --- a/net/rxrpc/call_object.c +++ b/net/rxrpc/call_object.c @@ -197,8 +197,6 @@ static int rxrpc_begin_client_call(struct rxrpc_call *call, if (ret < 0) return ret; - call->state = RXRPC_CALL_CLIENT_SEND_REQUEST; - spin_lock(&call->conn->params.peer->lock); hlist_add_head(&call->error_link, &call->conn->params.peer->error_targets); spin_unlock(&call->conn->params.peer->lock); |