summaryrefslogtreecommitdiff
path: root/tools/patman/patman.py
diff options
context:
space:
mode:
authorDoug Anderson <dianders@chromium.org>2012-12-03 14:40:42 +0000
committerSimon Glass <sjg@chromium.org>2013-01-31 15:23:39 -0800
commitd94566a1115d35f87db793d2daaa79823528937c (patch)
tree26cba53979275ad5e15661c8540ac188ed081a88 /tools/patman/patman.py
parentd96ef37df78eac5c636866d8f226991a5d96e6bb (diff)
patman: Cache the CC list from MakeCcFile() for use in ShowActions()
Currently we go through and generate the CC list for patches twice. This gets slow when (in a future CL) we add a call to get_maintainer.pl on Linux. Instead of doing things twice, just cache the CC list when it is first generated. Signed-off-by: Doug Anderson <dianders@chromium.org> Acked-by: Simon Glass <sjg@chromium.org>
Diffstat (limited to 'tools/patman/patman.py')
-rwxr-xr-xtools/patman/patman.py6
1 files changed, 4 insertions, 2 deletions
diff --git a/tools/patman/patman.py b/tools/patman/patman.py
index cfe06d0823..de8314a169 100755
--- a/tools/patman/patman.py
+++ b/tools/patman/patman.py
@@ -140,14 +140,16 @@ else:
options.count + options.start):
ok = False
+ cc_file = series.MakeCcFile(options.process_tags)
+
# Email the patches out (giving the user time to check / cancel)
cmd = ''
if ok or options.ignore_errors:
- cc_file = series.MakeCcFile(options.process_tags)
cmd = gitutil.EmailPatches(series, cover_fname, args,
options.dry_run, cc_file)
- os.remove(cc_file)
# For a dry run, just show our actions as a sanity check
if options.dry_run:
series.ShowActions(args, cmd, options.process_tags)
+
+ os.remove(cc_file)