summaryrefslogtreecommitdiff
path: root/unittests/Support
diff options
context:
space:
mode:
authorGeorge Karpenkov <ekarpenkov@apple.com>2018-06-13 18:32:02 +0000
committerGeorge Karpenkov <ekarpenkov@apple.com>2018-06-13 18:32:02 +0000
commitb97b3021fc7b9eb912c61f6c9dfd03f0e35b7cc4 (patch)
treef93b8372a01abcb105d6c77f9abca95e970f2075 /unittests/Support
parentba86f98ba71d995dc8d91b2e737ee09f4d59fd14 (diff)
Add checkMulAdd helper function to CheckedArithmetic
Multiplication followed by addition (https://en.wikipedia.org/wiki/Multiply–accumulate_operation) is a sufficiently common use-case to warrant a separate helper. Differential Revision: https://reviews.llvm.org/D48138 git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@334635 91177308-0d34-0410-b5e6-96231b3b80d8
Diffstat (limited to 'unittests/Support')
-rw-r--r--unittests/Support/CheckedArithmeticTest.cpp25
1 files changed, 25 insertions, 0 deletions
diff --git a/unittests/Support/CheckedArithmeticTest.cpp b/unittests/Support/CheckedArithmeticTest.cpp
index f797a9ed41e..18eee4c447e 100644
--- a/unittests/Support/CheckedArithmeticTest.cpp
+++ b/unittests/Support/CheckedArithmeticTest.cpp
@@ -32,6 +32,15 @@ TEST(CheckedArithmetic, CheckedMul) {
EXPECT_EQ(checkedMul<int64_t>(10, 2), Optional<int64_t>(20));
}
+TEST(CheckedArithmetic, CheckedMulAdd) {
+ const int64_t Max = std::numeric_limits<int64_t>::max();
+ const int64_t Min = std::numeric_limits<int64_t>::min();
+ EXPECT_EQ(checkedMulAdd<int64_t>(Max, 1, 2), None);
+ EXPECT_EQ(checkedMulAdd<int64_t>(1, 1, Max), None);
+ EXPECT_EQ(checkedMulAdd<int64_t>(1, -1, Min), None);
+ EXPECT_EQ(checkedMulAdd<int64_t>(10, 2, 3), Optional<int64_t>(23));
+}
+
TEST(CheckedArithmetic, CheckedMulSmall) {
const int16_t Max = std::numeric_limits<int16_t>::max();
const int16_t Min = std::numeric_limits<int16_t>::min();
@@ -41,6 +50,15 @@ TEST(CheckedArithmetic, CheckedMulSmall) {
EXPECT_EQ(checkedMul<int16_t>(10, 2), Optional<int16_t>(20));
}
+TEST(CheckedArithmetic, CheckedMulAddSmall) {
+ const int16_t Max = std::numeric_limits<int16_t>::max();
+ const int16_t Min = std::numeric_limits<int16_t>::min();
+ EXPECT_EQ(checkedMulAdd<int16_t>(Max, 1, 2), None);
+ EXPECT_EQ(checkedMulAdd<int16_t>(1, 1, Max), None);
+ EXPECT_EQ(checkedMulAdd<int16_t>(1, -1, Min), None);
+ EXPECT_EQ(checkedMulAdd<int16_t>(10, 2, 3), Optional<int16_t>(23));
+}
+
TEST(CheckedArithmetic, CheckedAddUnsigned) {
const uint64_t Max = std::numeric_limits<uint64_t>::max();
EXPECT_EQ(checkedAddUnsigned<uint64_t>(Max, Max), None);
@@ -55,5 +73,12 @@ TEST(CheckedArithmetic, CheckedMulUnsigned) {
EXPECT_EQ(checkedMulUnsigned<uint64_t>(10, 2), Optional<uint64_t>(20));
}
+TEST(CheckedArithmetic, CheckedMulAddUnsigned) {
+ const uint64_t Max = std::numeric_limits<uint64_t>::max();
+ EXPECT_EQ(checkedMulAddUnsigned<uint64_t>(Max, 1, 2), None);
+ EXPECT_EQ(checkedMulAddUnsigned<uint64_t>(1, 1, Max), None);
+ EXPECT_EQ(checkedMulAddUnsigned<uint64_t>(10, 2, 3), Optional<uint64_t>(23));
+}
+
} // namespace