From b97b3021fc7b9eb912c61f6c9dfd03f0e35b7cc4 Mon Sep 17 00:00:00 2001 From: George Karpenkov Date: Wed, 13 Jun 2018 18:32:02 +0000 Subject: Add checkMulAdd helper function to CheckedArithmetic MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Multiplication followed by addition (https://en.wikipedia.org/wiki/Multiply–accumulate_operation) is a sufficiently common use-case to warrant a separate helper. Differential Revision: https://reviews.llvm.org/D48138 git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@334635 91177308-0d34-0410-b5e6-96231b3b80d8 --- unittests/Support/CheckedArithmeticTest.cpp | 25 +++++++++++++++++++++++++ 1 file changed, 25 insertions(+) (limited to 'unittests/Support') diff --git a/unittests/Support/CheckedArithmeticTest.cpp b/unittests/Support/CheckedArithmeticTest.cpp index f797a9ed41e..18eee4c447e 100644 --- a/unittests/Support/CheckedArithmeticTest.cpp +++ b/unittests/Support/CheckedArithmeticTest.cpp @@ -32,6 +32,15 @@ TEST(CheckedArithmetic, CheckedMul) { EXPECT_EQ(checkedMul(10, 2), Optional(20)); } +TEST(CheckedArithmetic, CheckedMulAdd) { + const int64_t Max = std::numeric_limits::max(); + const int64_t Min = std::numeric_limits::min(); + EXPECT_EQ(checkedMulAdd(Max, 1, 2), None); + EXPECT_EQ(checkedMulAdd(1, 1, Max), None); + EXPECT_EQ(checkedMulAdd(1, -1, Min), None); + EXPECT_EQ(checkedMulAdd(10, 2, 3), Optional(23)); +} + TEST(CheckedArithmetic, CheckedMulSmall) { const int16_t Max = std::numeric_limits::max(); const int16_t Min = std::numeric_limits::min(); @@ -41,6 +50,15 @@ TEST(CheckedArithmetic, CheckedMulSmall) { EXPECT_EQ(checkedMul(10, 2), Optional(20)); } +TEST(CheckedArithmetic, CheckedMulAddSmall) { + const int16_t Max = std::numeric_limits::max(); + const int16_t Min = std::numeric_limits::min(); + EXPECT_EQ(checkedMulAdd(Max, 1, 2), None); + EXPECT_EQ(checkedMulAdd(1, 1, Max), None); + EXPECT_EQ(checkedMulAdd(1, -1, Min), None); + EXPECT_EQ(checkedMulAdd(10, 2, 3), Optional(23)); +} + TEST(CheckedArithmetic, CheckedAddUnsigned) { const uint64_t Max = std::numeric_limits::max(); EXPECT_EQ(checkedAddUnsigned(Max, Max), None); @@ -55,5 +73,12 @@ TEST(CheckedArithmetic, CheckedMulUnsigned) { EXPECT_EQ(checkedMulUnsigned(10, 2), Optional(20)); } +TEST(CheckedArithmetic, CheckedMulAddUnsigned) { + const uint64_t Max = std::numeric_limits::max(); + EXPECT_EQ(checkedMulAddUnsigned(Max, 1, 2), None); + EXPECT_EQ(checkedMulAddUnsigned(1, 1, Max), None); + EXPECT_EQ(checkedMulAddUnsigned(10, 2, 3), Optional(23)); +} + } // namespace -- cgit v1.2.3