summaryrefslogtreecommitdiff
path: root/tools/llvm-mca
diff options
context:
space:
mode:
authorAndrea Di Biagio <Andrea_DiBiagio@sn.scee.net>2018-07-11 12:44:44 +0000
committerAndrea Di Biagio <Andrea_DiBiagio@sn.scee.net>2018-07-11 12:44:44 +0000
commit483861bc32381cb649c6d9be416bd23798586ad6 (patch)
tree4e925b2c21e8bd2d209b42ae2cc87ac8821e8bbd /tools/llvm-mca
parent6c02a48ba4f910dab9a58d3fa6d4855bae5f335d (diff)
[llvm-mca] Use a different character to flag instructions with side-effects in the Instruction Info View. NFC
This makes easier to identify changes in the instruction info flags. It also helps spotting potential regressions similar to the one recently introduced at r336728. Using the same character to mark MayLoad/MayStore/HasSideEffects is problematic for llvm-lit. When pattern matching substrings, llvm-lit consumes tabs and spaces. A change in position of the flag marker may not trigger a test failure. This patch only changes the character used for flag `hasSideEffects`. The reason why I didn't touch other flags is because I want to avoid spamming the mailing because of the massive diff due to the numerous tests affected by this change. In future, each instruction flag should be associated with a different character in the Instruction Info View. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@336797 91177308-0d34-0410-b5e6-96231b3b80d8
Diffstat (limited to 'tools/llvm-mca')
-rw-r--r--tools/llvm-mca/InstructionInfoView.cpp4
1 files changed, 2 insertions, 2 deletions
diff --git a/tools/llvm-mca/InstructionInfoView.cpp b/tools/llvm-mca/InstructionInfoView.cpp
index 6bc4237334f..0e50a96d19c 100644
--- a/tools/llvm-mca/InstructionInfoView.cpp
+++ b/tools/llvm-mca/InstructionInfoView.cpp
@@ -29,7 +29,7 @@ void InstructionInfoView::printView(raw_ostream &OS) const {
TempStream << "\n\nInstruction Info:\n";
TempStream << "[1]: #uOps\n[2]: Latency\n[3]: RThroughput\n"
- << "[4]: MayLoad\n[5]: MayStore\n[6]: HasSideEffects\n\n";
+ << "[4]: MayLoad\n[5]: MayStore\n[6]: HasSideEffects (U)\n\n";
TempStream << "[1] [2] [3] [4] [5] [6] Instructions:\n";
for (unsigned I = 0, E = Instructions; I < E; ++I) {
@@ -73,7 +73,7 @@ void InstructionInfoView::printView(raw_ostream &OS) const {
}
TempStream << (MCDesc.mayLoad() ? " * " : " ");
TempStream << (MCDesc.mayStore() ? " * " : " ");
- TempStream << (MCDesc.hasUnmodeledSideEffects() ? " * " : " ");
+ TempStream << (MCDesc.hasUnmodeledSideEffects() ? " U " : " ");
MCIP.printInst(&Inst, InstrStream, "", STI);
InstrStream.flush();