summaryrefslogtreecommitdiff
path: root/include/linux/irqchip/arm-gic-v3.h
diff options
context:
space:
mode:
authorMarc Zyngier <marc.zyngier@arm.com>2018-03-06 21:44:37 +0000
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2018-03-21 12:05:45 +0100
commit3bf14279499c96539d5c0f06b54336c221ac7c63 (patch)
tree03ceec1aab57731e31fabce6be851fbec15e9eeb /include/linux/irqchip/arm-gic-v3.h
parent8853101329951ec551cd21d4a6f9c5c4b1a797a0 (diff)
kvm: arm/arm64: vgic-v3: Tighten synchronization for guests using v2 on v3
commit 27e91ad1e746e341ca2312f29bccb9736be7b476 upstream. On guest exit, and when using GICv2 on GICv3, we use a dsb(st) to force synchronization between the memory-mapped guest view and the system-register view that the hypervisor uses. This is incorrect, as the spec calls out the need for "a DSB whose required access type is both loads and stores with any Shareability attribute", while we're only synchronizing stores. We also lack an isb after the dsb to ensure that the latter has actually been executed before we start reading stuff from the sysregs. The fix is pretty easy: turn dsb(st) into dsb(sy), and slap an isb() just after. Cc: stable@vger.kernel.org Fixes: f68d2b1b73cc ("arm64: KVM: Implement vgic-v3 save/restore") Acked-by: Christoffer Dall <cdall@kernel.org> Reviewed-by: Andre Przywara <andre.przywara@arm.com> Signed-off-by: Marc Zyngier <marc.zyngier@arm.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'include/linux/irqchip/arm-gic-v3.h')
0 files changed, 0 insertions, 0 deletions