summaryrefslogtreecommitdiff
path: root/drivers/gpu/drm/tilcdc/tilcdc_external.h
diff options
context:
space:
mode:
authorLogan Gunthorpe <logang@deltatee.com>2017-12-05 16:30:51 -0700
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2018-03-24 11:02:47 +0100
commit75157d4e4d15d0938963c60fee3121eba2a6f5e5 (patch)
tree4ebb7d803af8fe20dfe24ca93218de5fc58f1fff /drivers/gpu/drm/tilcdc/tilcdc_external.h
parent73f483aa65d6a29fe25d9df30169bf1576d9770e (diff)
drm/tilcdc: ensure nonatomic iowrite64 is not used
[ Upstream commit 4e5ca2d930aa8714400aedf4bf1dc959cb04280f ] Add a check to ensure iowrite64 is only used if it is atomic. It was decided in [1] that the tilcdc driver should not be using an atomic operation (so it was left out of this patchset). However, it turns out that through the drm code, a nonatomic header is actually included: include/linux/io-64-nonatomic-lo-hi.h is included from include/drm/drm_os_linux.h:9:0, from include/drm/drmP.h:74, from include/drm/drm_modeset_helper.h:26, from include/drm/drm_atomic_helper.h:33, from drivers/gpu/drm/tilcdc/tilcdc_crtc.c:19: And thus, without this change, this patchset would inadvertantly change the behaviour of the tilcdc driver. [1] lkml.kernel.org/r/CAK8P3a2HhO_zCnsTzq7hmWSz5La5Thu19FWZpun16iMnyyNreQ@mail.gmail.com Signed-off-by: Logan Gunthorpe <logang@deltatee.com> Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com> Cc: Jyri Sarha <jsarha@ti.com> Cc: Arnd Bergmann <arnd@arndb.de> Cc: Tomi Valkeinen <tomi.valkeinen@ti.com> Cc: David Airlie <airlied@linux.ie> Signed-off-by: Jyri Sarha <jsarha@ti.com> Signed-off-by: Sasha Levin <alexander.levin@microsoft.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/gpu/drm/tilcdc/tilcdc_external.h')
0 files changed, 0 insertions, 0 deletions