blob: b67845ec84a04823890e07b9a484cc725a4f69ae (
plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
|
// RUN: %clang_cc1 -fsyntax-only -Wlogical-not-parentheses -verify %s
// RUN: %clang_cc1 -fsyntax-only -Wlogical-not-parentheses -fdiagnostics-parseable-fixits %s 2>&1 | FileCheck %s
int getInt();
int test1(int i1, int i2) {
int ret;
ret = !i1 == i2;
// expected-warning@-1 {{logical not is only applied to the left hand side of this comparison}}
// expected-note@-2 {{add parentheses after the '!' to evaluate the comparison first}}
// expected-note@-3 {{add parentheses around left hand side expression to silence this warning}}
// CHECK: warn-logical-not-compare.c:[[line:[0-9]*]]:9: warning
// CHECK: to evaluate the comparison first
// CHECK: fix-it:"{{.*}}":{[[line]]:10-[[line]]:10}:"("
// CHECK: fix-it:"{{.*}}":{[[line]]:18-[[line]]:18}:")"
// CHECK: to silence this warning
// CHECK: fix-it:"{{.*}}":{[[line]]:9-[[line]]:9}:"("
// CHECK: fix-it:"{{.*}}":{[[line]]:12-[[line]]:12}:")"
ret = !i1 != i2;
//expected-warning@-1 {{logical not is only applied to the left hand side of this comparison}}
// expected-note@-2 {{add parentheses after the '!' to evaluate the comparison first}}
// expected-note@-3 {{add parentheses around left hand side expression to silence this warning}}
// CHECK: warn-logical-not-compare.c:[[line:[0-9]*]]:9: warning
// CHECK: to evaluate the comparison first
// CHECK: fix-it:"{{.*}}":{[[line]]:10-[[line]]:10}:"("
// CHECK: fix-it:"{{.*}}":{[[line]]:18-[[line]]:18}:")"
// CHECK: to silence this warning
// CHECK: fix-it:"{{.*}}":{[[line]]:9-[[line]]:9}:"("
// CHECK: fix-it:"{{.*}}":{[[line]]:12-[[line]]:12}:")"
ret = !i1 < i2;
//expected-warning@-1 {{logical not is only applied to the left hand side of this comparison}}
// expected-note@-2 {{add parentheses after the '!' to evaluate the comparison first}}
// expected-note@-3 {{add parentheses around left hand side expression to silence this warning}}
// CHECK: warn-logical-not-compare.c:[[line:[0-9]*]]:9: warning
// CHECK: to evaluate the comparison first
// CHECK: fix-it:"{{.*}}":{[[line]]:10-[[line]]:10}:"("
// CHECK: fix-it:"{{.*}}":{[[line]]:17-[[line]]:17}:")"
// CHECK: to silence this warning
// CHECK: fix-it:"{{.*}}":{[[line]]:9-[[line]]:9}:"("
// CHECK: fix-it:"{{.*}}":{[[line]]:12-[[line]]:12}:")"
ret = !i1 > i2;
//expected-warning@-1 {{logical not is only applied to the left hand side of this comparison}}
// expected-note@-2 {{add parentheses after the '!' to evaluate the comparison first}}
// expected-note@-3 {{add parentheses around left hand side expression to silence this warning}}
// CHECK: warn-logical-not-compare.c:[[line:[0-9]*]]:9: warning
// CHECK: to evaluate the comparison first
// CHECK: fix-it:"{{.*}}":{[[line]]:10-[[line]]:10}:"("
// CHECK: fix-it:"{{.*}}":{[[line]]:17-[[line]]:17}:")"
// CHECK: to silence this warning
// CHECK: fix-it:"{{.*}}":{[[line]]:9-[[line]]:9}:"("
// CHECK: fix-it:"{{.*}}":{[[line]]:12-[[line]]:12}:")"
ret = !i1 <= i2;
//expected-warning@-1 {{logical not is only applied to the left hand side of this comparison}}
// expected-note@-2 {{add parentheses after the '!' to evaluate the comparison first}}
// expected-note@-3 {{add parentheses around left hand side expression to silence this warning}}
// CHECK: warn-logical-not-compare.c:[[line:[0-9]*]]:9: warning
// CHECK: to evaluate the comparison first
// CHECK: fix-it:"{{.*}}":{[[line]]:10-[[line]]:10}:"("
// CHECK: fix-it:"{{.*}}":{[[line]]:18-[[line]]:18}:")"
// CHECK: to silence this warning
// CHECK: fix-it:"{{.*}}":{[[line]]:9-[[line]]:9}:"("
// CHECK: fix-it:"{{.*}}":{[[line]]:12-[[line]]:12}:")"
ret = !i1 >= i2;
//expected-warning@-1 {{logical not is only applied to the left hand side of this comparison}}
// expected-note@-2 {{add parentheses after the '!' to evaluate the comparison first}}
// expected-note@-3 {{add parentheses around left hand side expression to silence this warning}}
// CHECK: warn-logical-not-compare.c:[[line:[0-9]*]]:9: warning
// CHECK: to evaluate the comparison first
// CHECK: fix-it:"{{.*}}":{[[line]]:10-[[line]]:10}:"("
// CHECK: fix-it:"{{.*}}":{[[line]]:18-[[line]]:18}:")"
// CHECK: to silence this warning
// CHECK: fix-it:"{{.*}}":{[[line]]:9-[[line]]:9}:"("
// CHECK: fix-it:"{{.*}}":{[[line]]:12-[[line]]:12}:")"
ret = i1 == i2;
ret = i1 != i2;
ret = i1 < i2;
ret = i1 > i2;
ret = i1 <= i2;
ret = i1 >= i2;
// Warning silenced by parens.
ret = (!i1) == i2;
ret = (!i1) != i2;
ret = (!i1) < i2;
ret = (!i1) > i2;
ret = (!i1) <= i2;
ret = (!i1) >= i2;
ret = !getInt() == i1;
// expected-warning@-1 {{logical not is only applied to the left hand side of this comparison}}
// expected-note@-2 {{add parentheses after the '!' to evaluate the comparison first}}
// expected-note@-3 {{add parentheses around left hand side expression to silence this warning}}
// CHECK: warn-logical-not-compare.c:[[line:[0-9]*]]:9: warning
// CHECK: to evaluate the comparison first
// CHECK: fix-it:"{{.*}}":{[[line]]:10-[[line]]:10}:"("
// CHECK: fix-it:"{{.*}}":{[[line]]:24-[[line]]:24}:")"
// CHECK: to silence this warning
// CHECK: fix-it:"{{.*}}":{[[line]]:9-[[line]]:9}:"("
// CHECK: fix-it:"{{.*}}":{[[line]]:18-[[line]]:18}:")"
ret = (!getInt()) == i1;
return ret;
}
enum E {e1, e2};
enum E getE();
int test2 (enum E e) {
int ret;
ret = e == e1;
ret = e == getE();
ret = getE() == e1;
ret = getE() == getE();
ret = !e == e1;
// expected-warning@-1 {{logical not is only applied to the left hand side of this comparison}}
// expected-note@-2 {{add parentheses after the '!' to evaluate the comparison first}}
// expected-note@-3 {{add parentheses around left hand side expression to silence this warning}}
// CHECK: warn-logical-not-compare.c:[[line:[0-9]*]]:9: warning
// CHECK: to evaluate the comparison first
// CHECK: fix-it:"{{.*}}":{[[line]]:10-[[line]]:10}:"("
// CHECK: fix-it:"{{.*}}":{[[line]]:17-[[line]]:17}:")"
// CHECK: to silence this warning
// CHECK: fix-it:"{{.*}}":{[[line]]:9-[[line]]:9}:"("
// CHECK: fix-it:"{{.*}}":{[[line]]:11-[[line]]:11}:")"
ret = !e == getE();
// expected-warning@-1 {{logical not is only applied to the left hand side of this comparison}}
// expected-note@-2 {{add parentheses after the '!' to evaluate the comparison first}}
// expected-note@-3 {{add parentheses around left hand side expression to silence this warning}}
// CHECK: warn-logical-not-compare.c:[[line:[0-9]*]]:9: warning
// CHECK: to evaluate the comparison first
// CHECK: fix-it:"{{.*}}":{[[line]]:10-[[line]]:10}:"("
// CHECK: fix-it:"{{.*}}":{[[line]]:21-[[line]]:21}:")"
// CHECK: to silence this warning
// CHECK: fix-it:"{{.*}}":{[[line]]:9-[[line]]:9}:"("
// CHECK: fix-it:"{{.*}}":{[[line]]:11-[[line]]:11}:")"
ret = !getE() == e1;
// expected-warning@-1 {{logical not is only applied to the left hand side of this comparison}}
// expected-note@-2 {{add parentheses after the '!' to evaluate the comparison first}}
// expected-note@-3 {{add parentheses around left hand side expression to silence this warning}}
// CHECK: warn-logical-not-compare.c:[[line:[0-9]*]]:9: warning
// CHECK: to evaluate the comparison first
// CHECK: fix-it:"{{.*}}":{[[line]]:10-[[line]]:10}:"("
// CHECK: fix-it:"{{.*}}":{[[line]]:22-[[line]]:22}:")"
// CHECK: to silence this warning
// CHECK: fix-it:"{{.*}}":{[[line]]:9-[[line]]:9}:"("
// CHECK: fix-it:"{{.*}}":{[[line]]:16-[[line]]:16}:")"
ret = !getE() == getE();
// expected-warning@-1 {{logical not is only applied to the left hand side of this comparison}}
// expected-note@-2 {{add parentheses after the '!' to evaluate the comparison first}}
// expected-note@-3 {{add parentheses around left hand side expression to silence this warning}}
// CHECK: warn-logical-not-compare.c:[[line:[0-9]*]]:9: warning
// CHECK: to evaluate the comparison first
// CHECK: fix-it:"{{.*}}":{[[line]]:10-[[line]]:10}:"("
// CHECK: fix-it:"{{.*}}":{[[line]]:26-[[line]]:26}:")"
// CHECK: to silence this warning
// CHECK: fix-it:"{{.*}}":{[[line]]:9-[[line]]:9}:"("
// CHECK: fix-it:"{{.*}}":{[[line]]:16-[[line]]:16}:")"
ret = !(e == e1);
ret = !(e == getE());
ret = !(getE() == e1);
ret = !(getE() == getE());
ret = (!e) == e1;
ret = (!e) == getE();
ret = (!getE()) == e1;
ret = (!getE()) == getE();
return ret;
}
int PR16673(int x) {
int ret;
// Make sure we don't emit a fixit for the left paren, but not the right paren.
#define X(x) x
ret = X(!x == 1 && 1);
// expected-warning@-1 {{logical not is only applied to the left hand side of this comparison}}
// expected-note@-2 {{add parentheses after the '!' to evaluate the comparison first}}
// expected-note@-3 {{add parentheses around left hand side expression to silence this warning}}
// CHECK: warn-logical-not-compare.c:[[line:[0-9]*]]:11: warning
// CHECK: to evaluate the comparison first
// CHECK-NOT: fix-it
// CHECK: to silence this warning
// CHECK-NOT: fix-it
return ret;
}
int compare_pointers(int* a, int* b) {
int ret;
ret = !!a == !!b;
ret = !!a != !!b;
return ret;
}
|
