1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
|
// RUN: %clang_analyze_cc1 -analyzer-checker=alpha.unix.PthreadLock -verify %s
// Tests performing normal locking patterns and wrong locking orders
#include "Inputs/system-header-simulator-for-pthread-lock.h"
pthread_mutex_t mtx1, mtx2;
pthread_mutex_t *pmtx;
lck_mtx_t lck1, lck2;
lck_grp_t grp1;
#define NULL 0
void
ok1(void)
{
pthread_mutex_lock(&mtx1); // no-warning
}
void
ok2(void)
{
pthread_mutex_unlock(&mtx1); // no-warning
}
void
ok3(void)
{
pthread_mutex_lock(&mtx1); // no-warning
pthread_mutex_unlock(&mtx1); // no-warning
pthread_mutex_lock(&mtx1); // no-warning
pthread_mutex_unlock(&mtx1); // no-warning
}
void
ok4(void)
{
pthread_mutex_lock(&mtx1); // no-warning
pthread_mutex_unlock(&mtx1); // no-warning
pthread_mutex_lock(&mtx2); // no-warning
pthread_mutex_unlock(&mtx2); // no-warning
}
void
ok5(void)
{
if (pthread_mutex_trylock(&mtx1) == 0) // no-warning
pthread_mutex_unlock(&mtx1); // no-warning
}
void
ok6(void)
{
lck_mtx_lock(&lck1); // no-warning
}
void
ok7(void)
{
if (lck_mtx_try_lock(&lck1) != 0) // no-warning
lck_mtx_unlock(&lck1); // no-warning
}
void
ok8(void)
{
pthread_mutex_lock(&mtx1); // no-warning
pthread_mutex_lock(&mtx2); // no-warning
pthread_mutex_unlock(&mtx2); // no-warning
pthread_mutex_unlock(&mtx1); // no-warning
}
void
ok9(void)
{
pthread_mutex_unlock(&mtx1); // no-warning
if (pthread_mutex_trylock(&mtx1) == 0) // no-warning
pthread_mutex_unlock(&mtx1); // no-warning
}
void
ok10(void)
{
if (pthread_mutex_trylock(&mtx1) != 0) // no-warning
pthread_mutex_lock(&mtx1); // no-warning
pthread_mutex_unlock(&mtx1); // no-warning
}
void
ok11(void)
{
pthread_mutex_destroy(&mtx1); // no-warning
}
void
ok12(void)
{
pthread_mutex_destroy(&mtx1); // no-warning
pthread_mutex_destroy(&mtx2); // no-warning
}
void
ok13(void)
{
pthread_mutex_unlock(&mtx1); // no-warning
pthread_mutex_destroy(&mtx1); // no-warning
}
void
ok14(void)
{
pthread_mutex_unlock(&mtx1); // no-warning
pthread_mutex_destroy(&mtx1); // no-warning
pthread_mutex_unlock(&mtx2); // no-warning
pthread_mutex_destroy(&mtx2); // no-warning
}
void
ok15(void)
{
pthread_mutex_lock(&mtx1); // no-warning
pthread_mutex_unlock(&mtx1); // no-warning
pthread_mutex_destroy(&mtx1); // no-warning
}
void
ok16(void)
{
pthread_mutex_init(&mtx1, NULL); // no-warning
}
void
ok17(void)
{
pthread_mutex_init(&mtx1, NULL); // no-warning
pthread_mutex_init(&mtx2, NULL); // no-warning
}
void
ok18(void)
{
pthread_mutex_destroy(&mtx1); // no-warning
pthread_mutex_init(&mtx1, NULL); // no-warning
}
void
ok19(void)
{
pthread_mutex_destroy(&mtx1); // no-warning
pthread_mutex_init(&mtx1, NULL); // no-warning
pthread_mutex_destroy(&mtx2); // no-warning
pthread_mutex_init(&mtx2, NULL); // no-warning
}
void
ok20(void)
{
pthread_mutex_unlock(&mtx1); // no-warning
pthread_mutex_destroy(&mtx1); // no-warning
pthread_mutex_init(&mtx1, NULL); // no-warning
pthread_mutex_destroy(&mtx1); // no-warning
pthread_mutex_init(&mtx1, NULL); // no-warning
}
void
ok21(void) {
pthread_mutex_lock(pmtx); // no-warning
pthread_mutex_unlock(pmtx); // no-warning
}
void
ok22(void) {
pthread_mutex_lock(pmtx); // no-warning
pthread_mutex_unlock(pmtx); // no-warning
pthread_mutex_lock(pmtx); // no-warning
pthread_mutex_unlock(pmtx); // no-warning
}
void ok23(void) {
if (pthread_mutex_destroy(&mtx1) != 0) // no-warning
pthread_mutex_destroy(&mtx1); // no-warning
}
void ok24(void) {
if (pthread_mutex_destroy(&mtx1) != 0) // no-warning
pthread_mutex_lock(&mtx1); // no-warning
}
void ok25(void) {
if (pthread_mutex_destroy(&mtx1) != 0) // no-warning
pthread_mutex_unlock(&mtx1); // no-warning
}
void ok26(void) {
pthread_mutex_unlock(&mtx1); // no-warning
if (pthread_mutex_destroy(&mtx1) != 0) // no-warning
pthread_mutex_lock(&mtx1); // no-warning
}
void ok27(void) {
pthread_mutex_unlock(&mtx1); // no-warning
if (pthread_mutex_destroy(&mtx1) != 0) // no-warning
pthread_mutex_lock(&mtx1); // no-warning
else
pthread_mutex_init(&mtx1, NULL); // no-warning
}
void ok28(void) {
if (pthread_mutex_destroy(&mtx1) != 0) { // no-warning
pthread_mutex_lock(&mtx1); // no-warning
pthread_mutex_unlock(&mtx1); // no-warning
pthread_mutex_destroy(&mtx1); // no-warning
}
}
void
bad1(void)
{
pthread_mutex_lock(&mtx1); // no-warning
pthread_mutex_lock(&mtx1); // expected-warning{{This lock has already been acquired}}
}
void
bad2(void)
{
pthread_mutex_lock(&mtx1); // no-warning
pthread_mutex_unlock(&mtx1); // no-warning
pthread_mutex_lock(&mtx1); // no-warning
pthread_mutex_lock(&mtx1); // expected-warning{{This lock has already been acquired}}
}
void
bad3(void)
{
pthread_mutex_lock(&mtx1); // no-warning
pthread_mutex_lock(&mtx2); // no-warning
pthread_mutex_unlock(&mtx1); // expected-warning{{This was not the most recently acquired lock}}
pthread_mutex_unlock(&mtx2);
}
void
bad4(void)
{
if (pthread_mutex_trylock(&mtx1)) // no-warning
return;
pthread_mutex_lock(&mtx2); // no-warning
pthread_mutex_unlock(&mtx1); // expected-warning{{This was not the most recently acquired lock}}
}
void
bad5(void)
{
lck_mtx_lock(&lck1); // no-warning
lck_mtx_lock(&lck1); // expected-warning{{This lock has already been acquired}}
}
void
bad6(void)
{
lck_mtx_lock(&lck1); // no-warning
lck_mtx_unlock(&lck1); // no-warning
lck_mtx_lock(&lck1); // no-warning
lck_mtx_lock(&lck1); // expected-warning{{This lock has already been acquired}}
}
void
bad7(void)
{
lck_mtx_lock(&lck1); // no-warning
lck_mtx_lock(&lck2); // no-warning
lck_mtx_unlock(&lck1); // expected-warning{{This was not the most recently acquired lock}}
lck_mtx_unlock(&lck2);
}
void
bad8(void)
{
if (lck_mtx_try_lock(&lck1) == 0) // no-warning
return;
lck_mtx_lock(&lck2); // no-warning
lck_mtx_unlock(&lck1); // expected-warning{{This was not the most recently acquired lock}}
}
void
bad9(void)
{
lck_mtx_unlock(&lck1); // no-warning
lck_mtx_unlock(&lck1); // expected-warning{{This lock has already been unlocked}}
}
void
bad10(void)
{
lck_mtx_lock(&lck1); // no-warning
lck_mtx_unlock(&lck1); // no-warning
lck_mtx_unlock(&lck1); // expected-warning{{This lock has already been unlocked}}
}
static void
bad11_sub(pthread_mutex_t *lock)
{
lck_mtx_unlock(lock); // expected-warning{{This lock has already been unlocked}}
}
void
bad11(int i)
{
lck_mtx_lock(&lck1); // no-warning
lck_mtx_unlock(&lck1); // no-warning
if (i < 5)
bad11_sub(&lck1);
}
void
bad12(void)
{
pthread_mutex_lock(&mtx1); // no-warning
pthread_mutex_unlock(&mtx1); // no-warning
pthread_mutex_lock(&mtx1); // no-warning
pthread_mutex_unlock(&mtx1); // no-warning
pthread_mutex_unlock(&mtx1); // expected-warning{{This lock has already been unlocked}}
}
void
bad13(void)
{
pthread_mutex_lock(&mtx1); // no-warning
pthread_mutex_unlock(&mtx1); // no-warning
pthread_mutex_lock(&mtx2); // no-warning
pthread_mutex_unlock(&mtx2); // no-warning
pthread_mutex_unlock(&mtx1); // expected-warning{{This lock has already been unlocked}}
}
void
bad14(void)
{
pthread_mutex_lock(&mtx1); // no-warning
pthread_mutex_lock(&mtx2); // no-warning
pthread_mutex_unlock(&mtx2); // no-warning
pthread_mutex_unlock(&mtx1); // no-warning
pthread_mutex_unlock(&mtx2); // expected-warning{{This lock has already been unlocked}}
}
void
bad15(void)
{
pthread_mutex_lock(&mtx1); // no-warning
pthread_mutex_lock(&mtx2); // no-warning
pthread_mutex_unlock(&mtx2); // no-warning
pthread_mutex_unlock(&mtx1); // no-warning
pthread_mutex_lock(&mtx1); // no-warning
pthread_mutex_unlock(&mtx2); // expected-warning{{This lock has already been unlocked}}
}
void
bad16(void)
{
pthread_mutex_destroy(&mtx1); // no-warning
pthread_mutex_lock(&mtx1); // expected-warning{{This lock has already been destroyed}}
}
void
bad17(void)
{
pthread_mutex_destroy(&mtx1); // no-warning
pthread_mutex_unlock(&mtx1); // expected-warning{{This lock has already been destroyed}}
}
void
bad18(void)
{
pthread_mutex_destroy(&mtx1); // no-warning
pthread_mutex_destroy(&mtx1); // expected-warning{{This lock has already been destroyed}}
}
void
bad19(void)
{
pthread_mutex_lock(&mtx1); // no-warning
pthread_mutex_destroy(&mtx1); // expected-warning{{This lock is still locked}}
}
void
bad20(void)
{
lck_mtx_destroy(&mtx1, &grp1); // no-warning
lck_mtx_lock(&mtx1); // expected-warning{{This lock has already been destroyed}}
}
void
bad21(void)
{
lck_mtx_destroy(&mtx1, &grp1); // no-warning
lck_mtx_unlock(&mtx1); // expected-warning{{This lock has already been destroyed}}
}
void
bad22(void)
{
lck_mtx_destroy(&mtx1, &grp1); // no-warning
lck_mtx_destroy(&mtx1, &grp1); // expected-warning{{This lock has already been destroyed}}
}
void
bad23(void)
{
lck_mtx_lock(&mtx1); // no-warning
lck_mtx_destroy(&mtx1, &grp1); // expected-warning{{This lock is still locked}}
}
void
bad24(void)
{
pthread_mutex_init(&mtx1, NULL); // no-warning
pthread_mutex_init(&mtx1, NULL); // expected-warning{{This lock has already been initialized}}
}
void
bad25(void)
{
pthread_mutex_lock(&mtx1); // no-warning
pthread_mutex_init(&mtx1, NULL); // expected-warning{{This lock is still being held}}
}
void
bad26(void)
{
pthread_mutex_unlock(&mtx1); // no-warning
pthread_mutex_init(&mtx1, NULL); // expected-warning{{This lock has already been initialized}}
}
void bad27(void) {
pthread_mutex_unlock(&mtx1); // no-warning
int ret = pthread_mutex_destroy(&mtx1); // no-warning
if (ret != 0) // no-warning
pthread_mutex_lock(&mtx1); // no-warning
else
pthread_mutex_unlock(&mtx1); // expected-warning{{This lock has already been destroyed}}
}
void bad28(void) {
pthread_mutex_unlock(&mtx1); // no-warning
int ret = pthread_mutex_destroy(&mtx1); // no-warning
if (ret != 0) // no-warning
pthread_mutex_lock(&mtx1); // no-warning
else
pthread_mutex_lock(&mtx1); // expected-warning{{This lock has already been destroyed}}
}
void bad29(void) {
pthread_mutex_lock(&mtx1); // no-warning
pthread_mutex_unlock(&mtx1); // no-warning
if (pthread_mutex_destroy(&mtx1) != 0) // no-warning
pthread_mutex_init(&mtx1, NULL); // expected-warning{{This lock has already been initialized}}
else
pthread_mutex_init(&mtx1, NULL); // no-warning
}
void bad30(void) {
pthread_mutex_lock(&mtx1); // no-warning
pthread_mutex_unlock(&mtx1); // no-warning
if (pthread_mutex_destroy(&mtx1) != 0) // no-warning
pthread_mutex_init(&mtx1, NULL); // expected-warning{{This lock has already been initialized}}
else
pthread_mutex_destroy(&mtx1); // expected-warning{{This lock has already been destroyed}}
}
void bad31(void) {
int ret = pthread_mutex_destroy(&mtx1); // no-warning
pthread_mutex_lock(&mtx1); // expected-warning{{This lock has already been destroyed}}
if (ret != 0)
pthread_mutex_lock(&mtx1);
}
|
