diff options
| author | Pierre Muller <muller@sourceware.org> | 2014-03-25 08:37:36 +0800 |
|---|---|---|
| committer | Yao Qi <yao@codesourcery.com> | 2014-04-08 14:07:28 +0800 |
| commit | ae1d276159c3cfb29caacdf567aea01f433f78b0 (patch) | |
| tree | b544a4b4e14da4e8556463f87d751f2bc824cfef /gdb/testsuite/gdb.base/printcmds.exp | |
| parent | ebb8ed8e946c7e48f64a3c2577403594c3971230 (diff) | |
[testsuite] Disable Ctrl-V use for mingw hosts.
On mingw host, we have seen two fails as below,
p int1dim[0]^V@2
Invalid character '^V' in expression.
(gdb) FAIL: gdb.base/printcmds.exp: p int1dim[0]@2
p int1dim[0]^V@2^V@3
Invalid character '^V' in expression.
(gdb) FAIL: gdb.base/printcmds.exp: p int1dim[0]@2@3
In the test, the comment says "# Send \026@ instead of just @ in case
the kill character is @". Historically, kill character was @, and
Ctrl-V (\026) is to escape the next character. However, we don't have
to do so on mingw. This patch is to disable ctrl-v usage on mingw
hots. With this patch applied, it becomes:
p int1dim[0]@2
$607 = {0, 1}
(gdb) PASS: gdb.base/printcmds.exp: p int1dim[0]@2
p int1dim[0]@2@3
$608 = {{0, 1}, {2, 3}, {4, 5}}
Note that this patch is picked from Pierre's submission,
[RFC 6/6] Fix remaining failures in gdb.base/printcmds.exp for mingw hosts.
https://www.sourceware.org/ml/gdb-patches/2013-09/msg00943.html
gdb/testsuite:
2014-04-08 Pierre Muller <muller@sourceware.org>
* gdb.base/printcmds.exp (test_artificial_arrays): Disable
Ctrl-V use for mingw hosts.
Diffstat (limited to 'gdb/testsuite/gdb.base/printcmds.exp')
| -rw-r--r-- | gdb/testsuite/gdb.base/printcmds.exp | 12 |
1 files changed, 10 insertions, 2 deletions
diff --git a/gdb/testsuite/gdb.base/printcmds.exp b/gdb/testsuite/gdb.base/printcmds.exp index a4b5b47583..c667aa9a0f 100644 --- a/gdb/testsuite/gdb.base/printcmds.exp +++ b/gdb/testsuite/gdb.base/printcmds.exp @@ -622,8 +622,16 @@ proc test_print_typedef_arrays {} { proc test_artificial_arrays {} { # Send \026@ instead of just @ in case the kill character is @. - gdb_test_escape_braces "p int1dim\[0\]\026@2" " = {0, 1}" {p int1dim[0]@2} - gdb_test_escape_braces "p int1dim\[0\]\026@2\026@3" \ + # \026 (ctrl-v) is to escape the next character (@), but it is + # not only unnecessary to do so on MingW hosts, but also harmful + # for the test because that character isn't recognized as an + # escape character. + set ctrlv "\026" + if [ishost *-*-mingw*] { + set ctrlv "" + } + gdb_test_escape_braces "p int1dim\[0\]${ctrlv}@2" " = {0, 1}" {p int1dim[0]@2} + gdb_test_escape_braces "p int1dim\[0\]${ctrlv}@2${ctrlv}@3" \ "({{0, 1}, {2, 3}, {4, 5}}|\[Cc\]annot.*)" \ {p int1dim[0]@2@3} gdb_test_escape_braces {p/x (short [])0x12345678} \ |