2010-06-11 Stan Shebs <stan@codesourcery.com>

	Add per-operation permission flags.

	* target.h (struct target_ops): New method to_set_permissions.
	(target_set_permissions): New macro.
	(target_insert_breakpoint): Change macro to function.
	(target_remove_breakpoint): Ditto.
	(target_stop): Ditto.
	(may_write_registers): Declare.
	(may_write_memory): Declare.
	(may_insert_breakpoints): Declare.
	(may_insert_tracepoints): Declare.
	(may_insert_fast_tracepoints): Declare.
	(may_stop): Declare.
	* target.c (may_write_registers, may_write_registers_1): New globals.
	(may_write_memory, may_write_memory_1): New globals.
	(may_insert_breakpoints, may_insert_breakpoints_1): New globals.
	(may_insert_tracepoints, may_insert_tracepoints_1): New globals.
	(may_insert_fast_tracepoints, may_insert_fast_tracepoints_1): New
	globals.
	(may_stop, may_stop_1): New global.
	(target_xfer_partial): Test for write permission.
	(target_store_registers): Ditto.
	(target_insert_breakpoint): New function.
	(target_remove_breakpoint): New function.
	(target_stop): New function.
	(_initialize_targets): Add new set/show variables.
	(set_write_memory_permission): New function.
	(update_target_permissions): New function.
	(set_target_permissions): New function.
	(update_current_target): Default to_set_permissions.
	(_initialize_targets): Use new globals and setter function.
	* tracepoint.c (start_tracing): Test for permission.
	* inferior.h (update_observer_mode): Declare.
	* infrun.c (non_stop_1): Define earlier.
	(observer_mode, observer_mode_1): New globals.
	(set_observer_mode, show_observer_mode): New functions.
	(update_observer_mode): New function.
	(_initialize_infrun): Define "set observer" command.
	* remote.c (PACKET_QAllow): New optional packet.
	(remote_protocol_features): Add QAllow.
	(remote_set_permissions): New function.
	(remote_start_remote): Call it.
	(init_remote_ops): Add it to target vector.
	(_initialize_remote): Add config command for QAllow.

	* gdb.texinfo (Observer Mode): New section.
	(General Query Packets): Document QAllow.

	* gdb.base/permissions.exp: New file.

1 files changed, 101 insertions, 0 deletions

diff --git a/gdb/testsuite/gdb.base/permissions.exp b/gdb/testsuite/gdb.base/permissions.exp
new file mode 100644
index 0000000000..c150093d44
--- /dev/null
+++ b/gdb/testsuite/gdb.base/permissions.exp
@@ -0,0 +1,101 @@
+# Copyright 2010 Free Software Foundation, Inc.
+
+# This program is free software; you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation; either version 3 of the License, or
+# (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program.  If not, see <http://www.gnu.org/licenses/>.
+
+# Tests for permissions and observer mode.
+
+# The permissions flags are only fully functional with stubs or targets
+# that can run asynchronously.
+
+set testfile permission
+set srcfile start.c
+set binfile ${objdir}/${subdir}/${testfile}
+
+if  { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile}" executable {debug nowarnings}] != "" } {
+     untested permissions.exp
+     return -1
+    }
+
+if [get_compiler_info $binfile] {
+    return -1
+}
+
+gdb_exit
+gdb_start
+gdb_reinitialize_dir $srcdir/$subdir
+
+gdb_test "show may-write-registers" \
+    "Permission to write into registers is on."
+
+gdb_test "show may-write-memory" \
+    "Permission to write into target memory is on."
+
+gdb_test "show may-insert-breakpoints" \
+    "Permission to insert breakpoints in the target is on."
+
+gdb_test "show may-insert-tracepoints" \
+    "Permission to insert tracepoints in the target is on."
+
+gdb_test "show may-insert-fast-tracepoints" \
+    "Permission to insert fast tracepoints in the target is on."
+
+gdb_test "show may-interrupt" \
+    "Permission to interrupt or signal the target is on."
+
+gdb_test "set observer on" "Observer mode is now on." "enable observer mode"
+
+gdb_test "show may-write-memory" \
+    "Permission to write into target memory is off."
+
+gdb_test "show may-write-registers" \
+    "Permission to write into registers is off."
+
+gdb_test "show may-insert-breakpoints" \
+    "Permission to insert breakpoints in the target is off."
+
+gdb_test "show may-insert-tracepoints" \
+    "Permission to insert tracepoints in the target is off."
+
+gdb_test "show may-insert-fast-tracepoints" \
+    "Permission to insert fast tracepoints in the target is on."
+
+gdb_test "show may-interrupt" \
+    "Permission to interrupt or signal the target is off."
+
+gdb_test "set observer off" "Observer mode is now off." "disable observer mode"
+
+# Go back to all-stop mode.
+
+gdb_test_no_output "set non-stop off"
+
+gdb_load ${binfile}
+
+if ![runto_main] then {
+    perror "couldn't run to breakpoint"
+    continue
+}
+
+gdb_test "print x = 45" "$decimal = 45" "set a global"
+
+gdb_test "print x" "$decimal = 45"
+
+gdb_test "set may-write-memory off"
+
+gdb_test "print x = 92" "Writing to memory is not allowed.*" \
+    "try to set a global"
+
+gdb_test "print x" "$decimal = 45"
+
+# FIXME Add tests for other flags when a testsuite-able target becomes
+# available.