summaryrefslogtreecommitdiff
path: root/gdb/memory-map.c
diff options
context:
space:
mode:
authorSimon Marchi <simon.marchi@ericsson.com>2017-10-21 12:06:22 -0400
committerSimon Marchi <simon.marchi@polymtl.ca>2017-10-21 12:06:22 -0400
commit6e17c56511104abd605bd2d122104467fc4f0089 (patch)
treeeb7995b7ea1d9f2348f698697f7a6d898374e05d /gdb/memory-map.c
parentcfba98720f62473abc54457a376a3b7aa7ab1e40 (diff)
Use std::string in memory_map_parsing_data
Replace the fixed-size array with a string. gdb/ChangeLog: * memory-map.c (struct memory_map_parsing_data) <property_name>: Change type to std::string. (memory_map_start_property): Adjust. (memory_map_end_property): Adjust.
Diffstat (limited to 'gdb/memory-map.c')
-rw-r--r--gdb/memory-map.c17
1 files changed, 9 insertions, 8 deletions
diff --git a/gdb/memory-map.c b/gdb/memory-map.c
index 0b2145649e..ff05394174 100644
--- a/gdb/memory-map.c
+++ b/gdb/memory-map.c
@@ -43,10 +43,11 @@ parse_memory_map (const char *memory_map)
/* Internal parsing data passed to all XML callbacks. */
struct memory_map_parsing_data
- {
- VEC(mem_region_s) **memory_map;
- char property_name[32];
- };
+{
+ VEC(mem_region_s) **memory_map;
+
+ std::string property_name;
+};
/* Handle the start of a <memory> element. */
@@ -103,7 +104,7 @@ memory_map_start_property (struct gdb_xml_parser *parser,
char *name;
name = (char *) xml_find_attribute (attributes, "name")->value;
- snprintf (data->property_name, sizeof (data->property_name), "%s", name);
+ data->property_name.assign (name);
}
/* Handle the end of a <property> element and its value. */
@@ -115,16 +116,16 @@ memory_map_end_property (struct gdb_xml_parser *parser,
{
struct memory_map_parsing_data *data
= (struct memory_map_parsing_data *) user_data;
- char *name = data->property_name;
- if (strcmp (name, "blocksize") == 0)
+ if (data->property_name == "blocksize")
{
struct mem_region *r = VEC_last (mem_region_s, *data->memory_map);
r->attrib.blocksize = gdb_xml_parse_ulongest (parser, body_text);
}
else
- gdb_xml_debug (parser, _("Unknown property \"%s\""), name);
+ gdb_xml_debug (parser, _("Unknown property \"%s\""),
+ data->property_name.c_str ());
}
/* Discard the constructed memory map (if an error occurs). */