diff options
| author | Mark Wielaard <mjw@redhat.com> | 2016-01-25 20:29:54 +0100 |
|---|---|---|
| committer | Mark Wielaard <mjw@redhat.com> | 2016-01-26 00:04:55 +0100 |
| commit | a579cd9aa8c57c8a54833f26452a1afef38e5d20 (patch) | |
| tree | c4644afae5892aef7114768ef5bdf2d0ae5e19cb /gdb/inflow.c | |
| parent | 00acd688caf385f38493ebd8d0a7b5f94d501a79 (diff) | |
Fix GCC6 -Wmisleading-indentation issues.
GCC6 will warn about misleading indentation issues like:
gdb/ada-lang.c: In function ‘ada_evaluate_subexp’:
ada-lang.c:11423:9: error: statement is indented as if it were guarded by...
arg1 = unwrap_value (arg1);
^~~~
gdb/ada-lang.c:11421:7: note: ...this ‘else’ clause, but it is not
else
^~~~
In this case it would be a bug except for the fact the if clause already
returned early. So this misindented statement really only got executed
for the else case. But it could easily mislead a reader, so adding a
proper else block is the correct solution.
In case of c-typeprint.c (c_type_print_base) the if statement is indeed
misleadingly indented, but not a bug. Just indent correctly. The inflow.c
(terminal_ours_1) misindented block comes from the removal of an if clause
in commit d9d2d8b which looks correct. Just introduce an else to fixup the
indentation of the block. The linux-record.c misleadingly indented return
statements are just that. Misleading to the reader, but not actual bugs.
Just unindent them so they don't look like they fall under the wrong if
clause.
Diffstat (limited to 'gdb/inflow.c')
| -rw-r--r-- | gdb/inflow.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/gdb/inflow.c b/gdb/inflow.c index bbd2b12ad7..4c80dbd896 100644 --- a/gdb/inflow.c +++ b/gdb/inflow.c @@ -412,7 +412,7 @@ child_terminal_ours_1 (int output_only) if (tinfo->run_terminal != NULL || gdb_has_a_terminal () == 0) return; - + else { #ifdef SIGTTOU /* Ignore this signal since it will happen when we try to set the |