Touches most files in bfd/, so likely will be blamed for everything..

o  bfd_read and bfd_write lose an unnecessary param and become
   bfd_bread and bfd_bwrite.

o  bfd_*alloc now all take a bfd_size_type arg, and will error if
   size_t is too small.  eg. 32 bit host, 64 bit bfd, verrry big files
   or bugs in linker scripts etc.

o  file_ptr becomes a bfd_signed_vma.  Besides matching sizes with
   various other types involved in handling sections, this should make
   it easier for bfd to support a 64 bit off_t on 32 bit hosts that
   provide it.

o  I've made the H_GET_* and H_PUT_* macros (which invoke bfd_h_{get,put}_*)
   generally available.  They now cast their args to bfd_vma and
   bfd_byte * as appropriate, which removes a swag of casts from the
   source.

o  Bug fixes to bfd_get8, aix386_core_vec, elf32_h8_relax_section, and
   aout-encap.c.

o  Zillions of formatting and -Wconversion fixes.

1 files changed, 124 insertions, 108 deletions

diff --git a/bfd/netbsd-core.c b/bfd/netbsd-core.c
index c93d6a4dc2..1c1a99ee04 100644
--- a/bfd/netbsd-core.c
+++ b/bfd/netbsd-core.c
@@ -1,5 +1,5 @@
 /* BFD back end for NetBSD style core files
-   Copyright 1988, 1989, 1991, 1992, 1993, 1996, 1998, 1999, 2000
+   Copyright 1988, 1989, 1991, 1992, 1993, 1996, 1998, 1999, 2000, 2001
    Free Software Foundation, Inc.
    Written by Paul Kranenburg, EUR
 
@@ -39,12 +39,12 @@ struct netbsd_core_struct {
 
 /* forward declarations */
 
-static const bfd_target *	netbsd_core_file_p PARAMS ((bfd *abfd));
-static char *		netbsd_core_file_failing_command PARAMS ((bfd *abfd));
-static int 		netbsd_core_file_failing_signal PARAMS ((bfd *abfd));
-static boolean		netbsd_core_file_matches_executable_p
-			 PARAMS ((bfd *core_bfd, bfd *exec_bfd));
-static void		swap_abort PARAMS ((void));
+static const bfd_target *netbsd_core_file_p PARAMS ((bfd *abfd));
+static char *netbsd_core_file_failing_command PARAMS ((bfd *abfd));
+static int netbsd_core_file_failing_signal PARAMS ((bfd *abfd));
+static boolean netbsd_core_file_matches_executable_p
+  PARAMS ((bfd *core_bfd, bfd *exec_bfd));
+static void swap_abort PARAMS ((void));
 
 /* Handle NetBSD-style core dump file.  */
 
@@ -54,117 +54,132 @@ netbsd_core_file_p (abfd)
      bfd *abfd;
 
 {
-	int		i, val, offset;
-	asection	*asect, *asect2;
-	struct core	core;
-	struct coreseg	coreseg;
-
-	val = bfd_read ((void *)&core, 1, sizeof core, abfd);
-	if (val != sizeof core) {
-		/* Too small to be a core file */
-		bfd_set_error(bfd_error_wrong_format);
-		return 0;
+  int i, val;
+  file_ptr offset;
+  asection *asect, *asect2;
+  struct core core;
+  struct coreseg coreseg;
+  bfd_size_type amt = sizeof core;
+
+  val = bfd_bread ((void *) &core, amt, abfd);
+  if (val != sizeof core)
+    {
+      /* Too small to be a core file */
+      bfd_set_error (bfd_error_wrong_format);
+      return 0;
+    }
+
+  if (CORE_GETMAGIC (core) != COREMAGIC)
+    {
+      bfd_set_error (bfd_error_wrong_format);
+      return 0;
+    }
+
+  amt = sizeof (struct netbsd_core_struct);
+  rawptr = (struct netbsd_core_struct *) bfd_zalloc (abfd, amt);
+  if (rawptr == NULL)
+    {
+      bfd_set_error (bfd_error_no_memory);
+      return 0;
+    }
+
+  rawptr->core = core;
+  abfd->tdata.netbsd_core_data = rawptr;
+
+  offset = core.c_hdrsize;
+  for (i = 0; i < core.c_nseg; i++)
+    {
+
+      if (bfd_seek (abfd, offset, SEEK_SET) != 0)
+	goto punt;
+
+      val = bfd_bread ((void *) &coreseg, (bfd_size_type) sizeof coreseg, abfd);
+      if (val != sizeof coreseg)
+	{
+	  bfd_set_error (bfd_error_file_truncated);
+	  goto punt;
 	}
-
-	if (CORE_GETMAGIC(core) != COREMAGIC) {
-		bfd_set_error(bfd_error_wrong_format);
-		return 0;
+      if (CORE_GETMAGIC (coreseg) != CORESEGMAGIC)
+	{
+	  bfd_set_error (bfd_error_wrong_format);
+	  goto punt;
 	}
 
-	rawptr = (struct netbsd_core_struct *)
-		bfd_zalloc (abfd, sizeof (struct netbsd_core_struct));
-	if (rawptr == NULL) {
-		bfd_set_error(bfd_error_no_memory);
-		return 0;
+      offset += core.c_seghdrsize;
+
+      amt = sizeof (asection);
+      asect = (asection *) bfd_zalloc (abfd, amt);
+      if (asect == NULL)
+	{
+	  bfd_set_error (bfd_error_no_memory);
+	  goto punt;
 	}
 
-	rawptr->core = core;
-	abfd->tdata.netbsd_core_data = rawptr;
-
-	offset = core.c_hdrsize;
-	for (i = 0; i < core.c_nseg; i++) {
-
-		if (bfd_seek (abfd, offset, SEEK_SET) != 0)
-			goto punt;
-
-		val = bfd_read ((void *)&coreseg, 1, sizeof coreseg, abfd);
-		if (val != sizeof coreseg) {
-			bfd_set_error(bfd_error_file_truncated);
-			goto punt;
-		}
-		if (CORE_GETMAGIC(coreseg) != CORESEGMAGIC) {
-			bfd_set_error(bfd_error_wrong_format);
-			goto punt;
-		}
-
-		offset += core.c_seghdrsize;
-
-		asect = (asection *) bfd_zalloc (abfd, sizeof (asection));
-		if (asect == NULL) {
-			bfd_set_error(bfd_error_no_memory);
-			goto punt;
-		}
-
-		asect->_raw_size = coreseg.c_size;
-		asect->vma = coreseg.c_addr;
-		asect->filepos = offset;
-		asect->alignment_power = 2;
-		asect->next = abfd->sections;
-		abfd->sections = asect;
-		abfd->section_count++;
-		offset += coreseg.c_size;
-
-		switch (CORE_GETFLAG(coreseg)) {
-		case CORE_CPU:
-			asect->name = ".reg";
-			asect->flags = SEC_ALLOC + SEC_HAS_CONTENTS;
+      asect->_raw_size = coreseg.c_size;
+      asect->vma = coreseg.c_addr;
+      asect->filepos = offset;
+      asect->alignment_power = 2;
+      asect->next = abfd->sections;
+      abfd->sections = asect;
+      abfd->section_count++;
+      offset += coreseg.c_size;
+
+      switch (CORE_GETFLAG(coreseg))
+	{
+	case CORE_CPU:
+	  asect->name = ".reg";
+	  asect->flags = SEC_ALLOC + SEC_HAS_CONTENTS;
 #ifdef CORE_FPU_OFFSET
-			/* Hackish...  */
-			asect->_raw_size = CORE_FPU_OFFSET;
-			asect2 = (asection *)bfd_zalloc (abfd,
-							 sizeof (asection));
-			if (asect2 == NULL) {
-				bfd_set_error(bfd_error_no_memory);
-				goto punt;
-			}
-			asect2->_raw_size = coreseg.c_size - CORE_FPU_OFFSET;
-			asect2->vma = 0;
-			asect2->filepos = asect->filepos + CORE_FPU_OFFSET;
-			asect2->alignment_power = 2;
-			asect2->next = abfd->sections;
-			asect2->name = ".reg2";
-			asect2->flags = SEC_ALLOC + SEC_HAS_CONTENTS;
-			abfd->sections = asect2;
-			abfd->section_count++;
+	  /* Hackish...  */
+	  asect->_raw_size = CORE_FPU_OFFSET;
+	  amt = sizeof (asection);
+	  asect2 = (asection *) bfd_zalloc (abfd, amt);
+	  if (asect2 == NULL)
+	    {
+	      bfd_set_error (bfd_error_no_memory);
+	      goto punt;
+	    }
+	  asect2->_raw_size = coreseg.c_size - CORE_FPU_OFFSET;
+	  asect2->vma = 0;
+	  asect2->filepos = asect->filepos + CORE_FPU_OFFSET;
+	  asect2->alignment_power = 2;
+	  asect2->next = abfd->sections;
+	  asect2->name = ".reg2";
+	  asect2->flags = SEC_ALLOC + SEC_HAS_CONTENTS;
+	  abfd->sections = asect2;
+	  abfd->section_count++;
 #endif
 
-			break;
-		case CORE_DATA:
-			asect->name = ".data";
-			asect->flags = SEC_ALLOC+SEC_LOAD+SEC_HAS_CONTENTS;
-			break;
-		case CORE_STACK:
-			asect->name = ".stack";
-			asect->flags = SEC_ALLOC+SEC_LOAD+SEC_HAS_CONTENTS;
-			break;
-		}
+	  break;
+	case CORE_DATA:
+	  asect->name = ".data";
+	  asect->flags = SEC_ALLOC+SEC_LOAD+SEC_HAS_CONTENTS;
+	  break;
+	case CORE_STACK:
+	  asect->name = ".stack";
+	  asect->flags = SEC_ALLOC+SEC_LOAD+SEC_HAS_CONTENTS;
+	  break;
 	}
+    }
 
-	/* OK, we believe you.  You're a core file (sure, sure).  */
-	return abfd->xvec;
+  /* OK, we believe you.  You're a core file (sure, sure).  */
+  return abfd->xvec;
 
-punt:	{
-		asection	*anext;
-		for (asect = abfd->sections; asect; asect = anext) {
-			anext = asect->next;
-			free((void *)asect);
-		}
-	}
-	free ((void *)rawptr);
-	abfd->tdata.netbsd_core_data = NULL;
-	abfd->sections = NULL;
-	abfd->section_count = 0;
-	return 0;
+ punt:
+  {
+    asection *anext;
+    for (asect = abfd->sections; asect; asect = anext)
+      {
+	anext = asect->next;
+	free ((void *) asect);
+      }
+  }
+
+  free ((void *) rawptr);
+  abfd->tdata.netbsd_core_data = NULL;
+  abfd->sections = NULL;
+  abfd->section_count = 0;
+  return 0;
 }
 
 static char*
@@ -187,7 +202,8 @@ netbsd_core_file_failing_signal (abfd)
 /* ARGSUSED */
 static boolean
 netbsd_core_file_matches_executable_p  (core_bfd, exec_bfd)
-     bfd *core_bfd, *exec_bfd;
+     bfd *core_bfd ATTRIBUTE_UNUSED;
+     bfd *exec_bfd ATTRIBUTE_UNUSED;
 {
   return true;		/* FIXME, We have no way of telling at this point */
 }