diff options
| author | Alan Modra <amodra@gmail.com> | 2017-11-02 08:05:03 +1030 |
|---|---|---|
| committer | Alan Modra <amodra@gmail.com> | 2017-11-05 09:37:33 +1030 |
| commit | 98bbb1b86180324b278842d8d73c79cb5d76d349 (patch) | |
| tree | 432703f6d0d970b0fc2ceb69009d71a50f281bc6 /bfd/elf64-ppc.c | |
| parent | 2e684e75ae3939f5f14fb89ca8a300b610d093dd (diff) | |
PowerPC readonly_dynrelocs
PowerPC64 lacked the mapfile textrel warning on finding dynamic relocs
in read-only sections. This patch adds it, and tidies the
readonly_dynrelocs interface. PowerPC doesn't need a SEC_ALLOC test
because !SEC_ALLOC sections are excluded by check_relocs so will never
have dyn_relocs.
* elf32-ppc.c (readonly_dynrelocs): Delete info param. Update all
callers. Don't bother with SEC_ALLOC test. Return section pointer.
Move minfo call to..
(maybe_set_textrel): ..here.
* elf64-ppc.c (readonly_dynrelocs): Return section pointer.
(maybe_set_textrel): Call minfo to print textrel warning to map file.
Diffstat (limited to 'bfd/elf64-ppc.c')
| -rw-r--r-- | bfd/elf64-ppc.c | 23 |
1 files changed, 15 insertions, 8 deletions
diff --git a/bfd/elf64-ppc.c b/bfd/elf64-ppc.c index 5cf862b2dc..bd42af072f 100644 --- a/bfd/elf64-ppc.c +++ b/bfd/elf64-ppc.c @@ -7084,10 +7084,9 @@ ppc64_elf_func_desc_adjust (bfd *obfd ATTRIBUTE_UNUSED, return TRUE; } -/* Return true if we have dynamic relocs against H that apply to - read-only sections. */ +/* Find dynamic relocs for H that apply to read-only sections. */ -static bfd_boolean +static asection * readonly_dynrelocs (struct elf_link_hash_entry *h) { struct ppc_link_hash_entry *eh; @@ -7099,9 +7098,9 @@ readonly_dynrelocs (struct elf_link_hash_entry *h) asection *s = p->sec->output_section; if (s != NULL && (s->flags & SEC_READONLY) != 0) - return TRUE; + return p->sec; } - return FALSE; + return NULL; } /* Return true if we have dynamic relocs against H or any of its weak @@ -9934,14 +9933,22 @@ size_global_entry_stubs (struct elf_link_hash_entry *h, void *inf) read-only sections. */ static bfd_boolean -maybe_set_textrel (struct elf_link_hash_entry *h, void *info) +maybe_set_textrel (struct elf_link_hash_entry *h, void *inf) { + asection *sec; + if (h->root.type == bfd_link_hash_indirect) return TRUE; - if (readonly_dynrelocs (h)) + sec = readonly_dynrelocs (h); + if (sec != NULL) { - ((struct bfd_link_info *) info)->flags |= DF_TEXTREL; + struct bfd_link_info *info = (struct bfd_link_info *) inf; + + info->flags |= DF_TEXTREL; + info->callbacks->minfo + (_("%B: dynamic relocation in read-only section `%A'\n"), + sec->owner, sec); /* Not an error, just cut short the traversal. */ return FALSE; |