From d0d7ef047c3e756d7480cdc4a78c690c7f1ccded Mon Sep 17 00:00:00 2001 From: Quentin Schulz Date: Fri, 13 Jan 2023 15:49:53 +0100 Subject: TSD: arm64: dts: rockchip: ringneck: move Video Demo adapter LED to its own device The "leds" device contains two LEDs, one on the SoM and one on the Haikou devkit. Those LEDs are almost guaranteed to always have the GPIO controller associated with their GPIO probed (because they are part GPIO controller from the SoC and enabled by default). However, the GPIO used for controlling the led on the Video Demo adapter is controlled by an external GPIO controller whose driver might not be built in. When one of the led child node of a gpio-leds device fails to find its GPIO, all led child nodes are "unprobed" and put in the deferred probe queue. In cases where the external GPIO controller driver is not built in, or not probed yet, or using the Video Demo adapter DTS without the actual HW, all LEDs will not be usable. Instead, let's move this adapter led to its own gpio-leds device so that it's only impacting this LED and not other ones that are known to work. Signed-off-by: Quentin Schulz --- arch/arm64/boot/dts/rockchip/px30-ringneck-haikou-video-demo.dts | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/arch/arm64/boot/dts/rockchip/px30-ringneck-haikou-video-demo.dts b/arch/arm64/boot/dts/rockchip/px30-ringneck-haikou-video-demo.dts index d82f2de50911..ec7c476f13a2 100644 --- a/arch/arm64/boot/dts/rockchip/px30-ringneck-haikou-video-demo.dts +++ b/arch/arm64/boot/dts/rockchip/px30-ringneck-haikou-video-demo.dts @@ -11,7 +11,10 @@ model = "Theobroma Systems PX30-µQ7 SoM on Haikou devkit with Video Demo adapter"; compatible = "tsd,px30-ringneck-haikou-video-demo", "tsd,px30-ringneck-haikou", "rockchip,px30"; - leds { + video-adapter-leds { + compatible = "gpio-leds"; + status = "okay"; + video-adapter-led { label = "video-adapter-led"; gpios = <&pca9670 7 GPIO_ACTIVE_HIGH>; -- cgit v1.2.3