From 666c81a3bbadf46ffd77e8f1c5bb6d76ceaf1d89 Mon Sep 17 00:00:00 2001 From: "eric.gao@rock-chips.com" Date: Thu, 20 Apr 2017 12:45:53 +0800 Subject: rockchip: video: vop: Fix rk_display_init() return error The function clk_set_rate() will return it's input parameter, so it's return value in normal condition is nonzero. In this case, we should report error when it return zero rather than return a nonzero value. Signed-off-by: Eric Gao --- drivers/video/rockchip/rk_vop.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers/video/rockchip/rk_vop.c b/drivers/video/rockchip/rk_vop.c index bc02f800dc..0691fdf8cd 100644 --- a/drivers/video/rockchip/rk_vop.c +++ b/drivers/video/rockchip/rk_vop.c @@ -242,11 +242,13 @@ int rk_display_init(struct udevice *dev, ulong fbbase, } ret = clk_get_by_index(dev, 1, &clk); - if (!ret) + if (!ret) { ret = clk_set_rate(&clk, timing.pixelclock.typ); - if (ret) { - debug("%s: Failed to set pixel clock: ret=%d\n", __func__, ret); - return ret; + if (!ret) { + debug("%s: Failed to set pixel clock: ret=%d\n", + __func__, ret); + return ret; + } } rkvop_mode_set(regs, &timing, vop_id); -- cgit v1.2.3