summaryrefslogtreecommitdiff
path: root/drivers/staging/skein
AgeCommit message (Collapse)Author
2015-10-24skein: fix coding styleAnton Tatuev
Added spaces around binary operators. Signed-off-by: Tatuev Anton <tatuev.a.a@yandex.ru> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2015-10-24staging: skein: Add space around '%'Burcin Akalin
Add space around operator '%'. Problem found using checkpatch.pl CHECK: spaces preferred around that '%' (ctx:VxV) Signed-off-by: Burcin Akalin <brcnakalin@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2015-10-16staging: skein: Remove useless initialisationAmitoj Kaur Chawla
Remove intialisation of a variable that is immediately reassigned. The semantic patch used to find this is: // <smpl> @@ type T; identifier x; constant C; expression e; @@ T x - = C ; x = e; // </smpl> Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2015-10-13Staging: skein: Remove NULL comparisonAybuke Ozdemir
Problem found using checkpatch.pl CHECK: Comparison to NULL could be written "key" Signed-off-by: Aybuke Ozdemir <aybuke.147@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2015-10-12Staging: skein: Remove space after castAybuke Ozdemir
Remove unnecessary space after cast. Problem found using checkpatch.pl CHECK: No space is necessary after a cast. Signed-off-by: Aybuke Ozdemir <aybuke.147@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2015-10-12Staging: skein: Remove multiple blank linesAybuke Ozdemir
Remove multiple blank lines. Problem found using checkpatch.pl CHECK: Please don't use multiple blank lines. Signed-off-by: Aybuke Ozdemir <aybuke.147@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2015-10-12staging: skein: remove extra indentationDeepa Dinamani
Fix macros containing do/while blocks to be indented uniformly. This patch fixes the checkpatch.pl warning: WARNING: suspect code indent for conditional statements Signed-off-by: Deepa Dinamani <deepa.kernel@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2015-10-12staging: skein: fix block comment styleDeepa Dinamani
Use a separate line for the opening marker of a comment block, a leading asterisk in front of subsequent lines in the block comment, and a separate line for the closing marker of the comment block. This patch fixes the checkpatch.pl warnings: WARNING: Block comments use a trailing */ on a separate line WARNING: Block comments use * on subsequent lines Signed-off-by: Deepa Dinamani <deepa.kernel@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2015-09-21staging: skein: Adds * on subsequent lines in block commentAmber N. Adams
This patch fixes the checkpatch.pl warning: WARNING: Block comments use * on subsequent lines +/* +Copyright (c) 2010 Werner Dittmann Signed-off-by: Amber N. Adams <amber@amberadams.co> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2015-05-31Drivers: staging: skein: skein_api: Fixed spelling errorsColin Cronin
Fixed a few spelling errors in comments. Signed-off-by: Colin Cronin <colinpatrickcronin@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2015-03-15Staging: skein: Remove do-while(0) from single statement macrosVatika Harlalka
Remove unneeded do-while(0) loop from single statement macros. Signed-off-by: Vatika Harlalka <vatikaharlalka@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2015-01-17staging: skein: Fixing single statement macro checkpatch warningMathieu Poirier
WARNING: Single statement macros should not use a do {} while (0) loop Signed-off-by: Mathieu Poirier <mathieu.poirier@linaro.org> Acked-by: Jason Cooper <jason@lakedaemon.net> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2015-01-17staging: skein: Fixing trailing whitespace errorMathieu Poirier
Signed-off-by: Mathieu Poirier <mathieu.poirier@linaro.org> Acked-by: Jason Cooper <jason@lakedaemon.net> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-11-22staging: skein: fix sparse warnings related to shift operatorDomagoj Trsan
Fix warnings: drivers/staging/skein/skein_base.h:89:30: warning: shift too big (50) for type int ... drivers/staging/skein/skein_base.h:89:30: warning: shift too big (39)for type int drivers/staging/skein/skein_base.h:89:19: warning: too many warnings Signed-off-by: Domagoj Trsan <domagoj.trsan@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-11-22staging: skein: fixed sparse warnings related to static declarationsNiklas Svensson
drivers/staging/skein/skein_generic.c:30:5: warning: symbol 'skein256_update' was not declared. Should it be static? drivers/staging/skein/skein_generic.c:65:5: warning: symbol 'skein512_update' was not declared. Should it be static? drivers/staging/skein/skein_generic.c:100:5: warning: symbol 'skein1024_update' was not declared. Should it be static? Signed-off-by: Niklas Svensson <nks@flawful.org> Acked-by: Jason Cooper <jason@lakedaemon.net> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-10-30staging: skein: Removes skein_debug includeEric Rost
Removes skein_debug.h include since skein_debug.h is nonexistent. Removes unneeded debug empty macro defines and their uses. Signed-off-by: Eric Rost <eric.rost@mybabylon.net> Reviewed-by: Jason Cooper <jason@lakedaemon.net> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-10-29staging: skein: skein_api.c: removed space before ','Mikael Svantesson
Signed-off-by: Mikael Svantesson <mikael@distopic.net> Acked-by: Jason Cooper <jason@lakedaemon.net> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-10-29staging: skein: Removes unneeded #defineEric Rost
Removes unneeded #define SKEIN_PORT_CODE since skein_port.h is nonexistent. Signed-off-by: Eric Rost <eric.rost@mybabylon.net> Reviewed-by: Jason Cooper <jason@lakedaemon.net> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-10-29staging: skein: Inlines rotl_64Eric Rost
Inlines the rotl_64 macro. Signed-off-by: Eric Rost <eric.rost@mybabylon.net> Reviewed-by: Jason Cooper <jason@lakedaemon.net> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-10-29staging: skein: Adds Loadable Module SupportEric Rost
Adds loadable module support to the Skein Hashing Algorithm driver. Signed-off-by: Eric Rost <eric.rost@mybabylon.net> Reviewed-by: Jason Cooper <jason@lakedaemon.net> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-10-29staging: skein: Adds CryptoAPI SupportEric Rost
Adds CryptoAPI support to the Skein Hashing Algorithm driver. Signed-off-by: Eric Rost <eric.rost@mybabylon.net> Reviewed-by: Jason Cooper <jason@lakedaemon.net> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-10-29staging: skein: Renames skein to skein_baseEric Rost
Renames skein.c to skein_base.c and skein.h to skein_base.h in preparation for naming loadable module skein.ko Signed-off-by: Eric Rost <eric.rost@mybabylon.net> Reviewed-by: Jason Cooper <jason@lakedaemon.net> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-10-29staging: skein: Collapses threefish moduleEric Rost
Collapses threefish module into skein module. Signed-off-by: Eric Rost <eric.rost@mybabylon.net> Reviewed-by: Jason Cooper <jason@lakedaemon.net> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-10-20staging: skein: File ReorgEric Rost
Reorganizes file to remove #defines from middle of functions. Also removes #if'd loop declarations and adds ternary if driven loops. Signed-off-by: Eric Rost <eric.rost@mybabylon.net> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-10-20staging: skein: Whitespace cleanupEric Rost
Pretties up multiline #defines and many other whitespace issues Signed-off-by: Eric Rost <eric.rost@mybabylon.net> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-09-19staging: skein: replace spaces with tabsBlaj Roxana
This fixes the error and warning: ERROR: code indent should use tabs where possible WARNING: please, no spaces at the start of a line Signed-off-by: Blaj Roxana <roxanagabriela10@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-06-19staging: skein: fix sparse warning for static arraysJames A Shackleford
This patch fixes the following sparse warnings: skein_iv.h:23:11: warning: symbol 'SKEIN_256_IV_128' was not declared. Should it be static? skein_iv.h:31:11: warning: symbol 'SKEIN_256_IV_160' was not declared. Should it be static? skein_iv.h:39:11: warning: symbol 'SKEIN_256_IV_224' was not declared. Should it be static? skein_iv.h:47:11: warning: symbol 'SKEIN_256_IV_256' was not declared. Should it be static? skein_iv.h:55:11: warning: symbol 'SKEIN_512_IV_128' was not declared. Should it be static? skein_iv.h:67:11: warning: symbol 'SKEIN_512_IV_160' was not declared. Should it be static? skein_iv.h:79:11: warning: symbol 'SKEIN_512_IV_224' was not declared. Should it be static? skein_iv.h:91:11: warning: symbol 'SKEIN_512_IV_256' was not declared. Should it be static? skein_iv.h:103:11: warning: symbol 'SKEIN_512_IV_384' was not declared. Should it be static? skein_iv.h:115:11: warning: symbol 'SKEIN_512_IV_512' was not declared. Should it be static? skein_iv.h:127:11: warning: symbol 'SKEIN_1024_IV_384' was not declared. Should it be static? skein_iv.h:147:11: warning: symbol 'SKEIN_1024_IV_512' was not declared. Should it be static? skein_iv.h:167:11: warning: symbol 'SKEIN_1024_IV_1024' was not declared. Should it be static? by declaring the initialization vectors in question as static. The header skein_iv.h is only included by skein.c Signed-off-by: James A Shackleford <shack@linux.com> Acked-by: Jason Cooper <jason@lakedaemon.net> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-06-01staging: skein: fix sparse warning for static declarationsJames A Shackleford
This patch fixes the following sparse warnings: skein_block.c:43:6: warning: symbol 'skein_256_process_block' was not declared. Should it be static? skein_block.c:252:6: warning: symbol 'skein_512_process_block' was not declared. Should it be static? skein_block.c:483:6: warning: symbol 'skein_1024_process_block' was not declared. Should it be static? by including the header skein_block.h, which contains the declarations in question. Signed-off-by: James A Shackleford <shack@linux.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-21staging/skein: variable/member name cleanupJake Edge
Rename a few more variables and structure member names to lower case. Signed-off-by: Jake Edge <jake@lwn.net> Acked-by: Jason Cooper <jason@lakedaemon.net> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-21staging/skein: comment typosJake Edge
fix some comment typos Signed-off-by: Jake Edge <jake@lwn.net> Acked-by: Jason Cooper <jason@lakedaemon.net> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-21staging/skein: move all threefish block functions to one fileJake Edge
move all threefish block functions to one file, remove unneeded include Signed-off-by: Jake Edge <jake@lwn.net> Acked-by: Jason Cooper <jason@lakedaemon.net> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-19staging/skein: rename files and clean up directory structureJake Edge
Clean up file names and locations. Get rid of include/ directory and move those up to the top-level. Rename files to get rid of upper case. Remove skeinBlockNo3F.c as it was unused (temporary file or something?). Signed-off-by: Jake Edge <jake@lwn.net> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-19staging: crypto: skein: rename macrosAnton Saraev
Mixing upper and lower case in names of macros like It_Is_Macro is not accepted in the Linux Kernel. To prepare skein driver for mainline inclusion, we rename all macros to uppercase or lowercase names. Signed-off-by: Anton Saraev <antonysaraev@gmail.com> Reviewed-by: Jake Edge <jake@lwn.net> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-19staging: crypto: skein: rename enumsAnton Saraev
Linux Kernel use capitalized names for enum. To prepare skein driver to mainline inclusion, we rename all enums to capitalized names. Signed-off-by: Anton Saraev <antonysaraev@gmail.com> Reviewed-by: Jake Edge <jake@lwn.net> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-19staging: crypto: skein: rename skein1024_ctx to skein_1024_ctxAnton Saraev
Code have skein_512_ctx and skein_256_ctx but skein1024_ctx. It would be logical to convert these names to a single form. Signed-off-by: Anton Saraev <antonysaraev@gmail.com> Reviewed-by: Jake Edge <jake@lwn.net> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-19staging: crypto: skein: rename camelcase varsAnton Saraev
camelCase is not accepted in the Linux Kernel. To prepare skein driver for mainline inclusion, we rename all vars to non-camelCase equivalents. Signed-off-by: Anton Saraev <antonysaraev@gmail.com> Reviewed-by: Jake Edge <jake@lwn.net> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-19staging: crypto: skein: rename camelcase functionsAnton Saraev
camelCase is not accepted in the Linux Kernel. To prepare skein driver for mainline inclusion, we rename all functions to non-camelCase equivalents. Signed-off-by: Anton Saraev <antonysaraev@gmail.com> Reviewed-by: Jake Edge <jake@lwn.net> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-19staging: crypto: skein: depend upon CRYPTOJason Cooper
Fengguang's randconfig kernel build tester discovered the following warnings: warning: (CRYPTO_THREEFISH) selects CRYPTO_ALGAPI which has unmet direct dependencies (CRYPTO) warning: (DM_VERITY && CRYPTO_SKEIN) selects CRYPTO_HASH which has unmet direct dependencies (CRYPTO) Fix this in the Kconfig by depending on CRYPTO. Reported-by: Fengguang Wu <fengguang.wu@intel.com> Signed-off-by: Jason Cooper <jason@lakedaemon.net> Reviewed-by: Marek Vasut <marex@denx.de> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-04-18staging: crypto: skein: add TODO fileJason Cooper
Signed-off-by: Jason Cooper <jason@lakedaemon.net> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-04-18staging: crypto: skein: remove unnecessary line continuationJason Cooper
Signed-off-by: Jason Cooper <jason@lakedaemon.net> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-04-18staging: crypto: skein: remove braces from single-statement blockJason Cooper
Signed-off-by: Jason Cooper <jason@lakedaemon.net> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-04-18staging: crypto: skein: remove externs from .c filesJason Cooper
Signed-off-by: Jason Cooper <jason@lakedaemon.net> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-04-18staging: crypto: skein: wrap multi-line macros in do-while loopsJason Cooper
Signed-off-by: Jason Cooper <jason@lakedaemon.net> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-04-18staging: crypto: skein: fix brace placement errorsJason Cooper
Signed-off-by: Jason Cooper <jason@lakedaemon.net> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-04-18staging: crypto: skein: fix do/while brace formattingJason Cooper
Signed-off-by: Jason Cooper <jason@lakedaemon.net> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-04-18staging: crypto: skein: cleanup >80 character linesJason Cooper
Signed-off-by: Jason Cooper <jason@lakedaemon.net> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-04-18staging: crypto: skein: remove trailing whitespaceJason Cooper
Signed-off-by: Jason Cooper <jason@lakedaemon.net> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-04-18staging: crypto: skein: fix leading whitespaceJason Cooper
Signed-off-by: Jason Cooper <jason@lakedaemon.net> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-04-18staging: crypto: skein: dos2unix, remove executable permsJason Cooper
$ find drivers/staging/skein -type f | xargs todos -d $ chmod -x drivers/staging/skein/skeinApi.c $ chmod -x drivers/staging/skein/include/skeinApi.h Signed-off-by: Jason Cooper <jason@lakedaemon.net> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-04-18staging: crypto: skein: cleanup whitespace around operators/punc.Jason Cooper
Signed-off-by: Jason Cooper <jason@lakedaemon.net> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>