diff options
| author | David S. Miller <davem@davemloft.net> | 2015-05-01 22:02:47 -0400 |
|---|---|---|
| committer | Zefan Li <lizefan@huawei.com> | 2015-09-18 09:20:46 +0800 |
| commit | 7014d74fb26f9adbd5e275f1858c2aae16e35769 (patch) | |
| tree | bc5bec5127386ac5a6fd68cbc647a3157fa8c1b2 /net | |
| parent | 842c36214f1d1715a30ede9430658411a349c839 (diff) | |
ipv4: Missing sk_nulls_node_init() in ping_unhash().
commit a134f083e79fb4c3d0a925691e732c56911b4326 upstream.
If we don't do that, then the poison value is left in the ->pprev
backlink.
This can cause crashes if we do a disconnect, followed by a connect().
Tested-by: Linus Torvalds <torvalds@linux-foundation.org>
Reported-by: Wen Xu <hotdog3645@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Zefan Li <lizefan@huawei.com>
Diffstat (limited to 'net')
| -rw-r--r-- | net/ipv4/ping.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/net/ipv4/ping.c b/net/ipv4/ping.c index cb9085272dd7..9f471c32d209 100644 --- a/net/ipv4/ping.c +++ b/net/ipv4/ping.c @@ -138,6 +138,7 @@ static void ping_v4_unhash(struct sock *sk) if (sk_hashed(sk)) { write_lock_bh(&ping_table.lock); hlist_nulls_del(&sk->sk_nulls_node); + sk_nulls_node_init(&sk->sk_nulls_node); sock_put(sk); isk->inet_num = 0; isk->inet_sport = 0; |