diff options
| author | Hugh Dickins <hugh@veritas.com> | 2009-04-16 21:58:12 +0100 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@suse.de> | 2010-08-20 11:25:12 -0700 |
| commit | 01ee2e1e3041f41722ef3ae49e95f04086dbd320 (patch) | |
| tree | 5414effbde9473d5e6a6a3e435f51e2b30d84920 | |
| parent | a980300e27c138836e2cc515e53f83e4d1a0505b (diff) | |
mm: pass correct mm when growing stack
commit 05fa199d45c54a9bda7aa3ae6537253d6f097aa9 upstream.
Tetsuo Handa reports seeing the WARN_ON(current->mm == NULL) in
security_vm_enough_memory(), when do_execve() is touching the
target mm's stack, to set up its args and environment.
Yes, a UMH_NO_WAIT or UMH_WAIT_PROC call_usermodehelper() spawns
an mm-less kernel thread to do the exec. And in any case, that
vm_enough_memory check when growing stack ought to be done on the
target mm, not on the execer's mm (though apart from the warning,
it only makes a slight tweak to OVERCOMMIT_NEVER behaviour).
Reported-by: Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>
Signed-off-by: Hugh Dickins <hugh@veritas.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
| -rw-r--r-- | mm/mmap.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/mm/mmap.c b/mm/mmap.c index f3e5bfecf7b5..08a32cfabd5d 100644 --- a/mm/mmap.c +++ b/mm/mmap.c @@ -1573,7 +1573,7 @@ static int acct_stack_growth(struct vm_area_struct * vma, unsigned long size, un * Overcommit.. This must be the final test, as it will * update security statistics. */ - if (security_vm_enough_memory(grow)) + if (security_vm_enough_memory_mm(mm, grow)) return -ENOMEM; /* Ok, everything looks good - let it rip */ |