diff options
| author | dan.carpenter@oracle.com <dan.carpenter@oracle.com> | 2013-06-09 16:07:28 +0300 |
|---|---|---|
| committer | Willy Tarreau <w@1wt.eu> | 2016-08-27 11:40:41 +0200 |
| commit | 51ace2618a8647a2031981b088a91635dc0d3e04 (patch) | |
| tree | f6e2a0d6a323bf9a8c45cde3088a0b978dd0e6dc | |
| parent | 78308a4a651d1b6c4851f84d09ba0edb9803df97 (diff) | |
spi: spi-xilinx: cleanup a check in xilinx_spi_txrx_bufs()
commit e33d085d11e54bc9fb07b2555cd104d8e7b3089b upstream.
'!' has higher precedence than comparisons so the original condition
is equivalent to "if (xspi->remaining_bytes == 0)". This makes the
static checkers complain.
xspi->remaining_bytes is signed and from looking at the code
briefly, I think it might be able to go negative. I suspect that
going negative may cause a bug, but I don't have the hardware and
can't test.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Mark Brown <broonie@linaro.org>
Signed-off-by: Willy Tarreau <w@1wt.eu>
| -rw-r--r-- | drivers/spi/spi-xilinx.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/spi/spi-xilinx.c b/drivers/spi/spi-xilinx.c index 34d18dcfa0db..109a535b639c 100644 --- a/drivers/spi/spi-xilinx.c +++ b/drivers/spi/spi-xilinx.c @@ -315,7 +315,7 @@ static int xilinx_spi_txrx_bufs(struct spi_device *spi, struct spi_transfer *t) } /* See if there is more data to send */ - if (!xspi->remaining_bytes > 0) + if (xspi->remaining_bytes <= 0) break; } |