diff options
| author | Philipp Tomsich <philipp.tomsich@theobroma-systems.com> | 2017-02-14 12:47:18 +0100 |
|---|---|---|
| committer | Philipp Tomsich <philipp.tomsich@theobroma-systems.com> | 2017-03-09 01:40:18 +0100 |
| commit | ef1cbfb28ab1f1104d51449a1fae070aec9f2aa1 (patch) | |
| tree | 235a73e25d9eae91b1822d6485c51f31b2e1618c /drivers/net/sun8i_emac.c | |
| parent | e98553a3695f846de4ce39cce04c248b24fd94f6 (diff) | |
sun8i_emac: remove unnecessary bit-masking for mdio_read/write
The MDIO read/write builds up the MII_CMD register from scratch (starting
with a value of 0). No need to mask out any fields before writing the new
values.
Signed-off-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
Reviewed-by: Andre Przywara <andre.przywara@arm.com>
Acked-by: Maxime Ripard <maxime.ripard@free-electrons.com>
Diffstat (limited to 'drivers/net/sun8i_emac.c')
| -rw-r--r-- | drivers/net/sun8i_emac.c | 8 |
1 files changed, 0 insertions, 8 deletions
diff --git a/drivers/net/sun8i_emac.c b/drivers/net/sun8i_emac.c index 5ae17b7611..5094dd8428 100644 --- a/drivers/net/sun8i_emac.c +++ b/drivers/net/sun8i_emac.c @@ -143,13 +143,8 @@ static int sun8i_mdio_read(struct mii_dev *bus, int addr, int devad, int reg) u32 miiaddr = 0; int timeout = CONFIG_MDIO_TIMEOUT; - miiaddr &= ~MDIO_CMD_MII_WRITE; - miiaddr &= ~MDIO_CMD_MII_PHY_REG_ADDR_MASK; miiaddr |= (reg << MDIO_CMD_MII_PHY_REG_ADDR_SHIFT) & MDIO_CMD_MII_PHY_REG_ADDR_MASK; - - miiaddr &= ~MDIO_CMD_MII_PHY_ADDR_MASK; - miiaddr |= (addr << MDIO_CMD_MII_PHY_ADDR_SHIFT) & MDIO_CMD_MII_PHY_ADDR_MASK; @@ -179,11 +174,8 @@ static int sun8i_mdio_write(struct mii_dev *bus, int addr, int devad, int reg, u32 miiaddr = 0; int ret = -1, timeout = CONFIG_MDIO_TIMEOUT; - miiaddr &= ~MDIO_CMD_MII_PHY_REG_ADDR_MASK; miiaddr |= (reg << MDIO_CMD_MII_PHY_REG_ADDR_SHIFT) & MDIO_CMD_MII_PHY_REG_ADDR_MASK; - - miiaddr &= ~MDIO_CMD_MII_PHY_ADDR_MASK; miiaddr |= (addr << MDIO_CMD_MII_PHY_ADDR_SHIFT) & MDIO_CMD_MII_PHY_ADDR_MASK; |