summaryrefslogtreecommitdiff
path: root/base
diff options
context:
space:
mode:
authorSpencer Low <CompareAndSwap@gmail.com>2015-09-01 14:57:58 -0700
committerSpencer Low <CompareAndSwap@gmail.com>2015-09-01 14:57:58 -0700
commit2fbeb0cc713f47ec699bfed4bc530aa19e08e1a3 (patch)
treefa660894431d56b1c3b1d05f1830191e6a19b24e /base
parent78ea165ea24e83a979939153ed4d3b075c07a779 (diff)
adb/base win32 tests: fix comment and open() flags
Match base's use of O_BINARY. Change-Id: I930b5c8fddde20966580069f2e681b99cb26f1a3 Signed-off-by: Spencer Low <CompareAndSwap@gmail.com>
Diffstat (limited to 'base')
-rw-r--r--base/test_utils.cpp6
1 files changed, 3 insertions, 3 deletions
diff --git a/base/test_utils.cpp b/base/test_utils.cpp
index b0c5a12c0..22641e79d 100644
--- a/base/test_utils.cpp
+++ b/base/test_utils.cpp
@@ -37,9 +37,9 @@ int mkstemp(char* template_name) {
return -1;
}
// Use open() to match the close() that TemporaryFile's destructor does.
- // Note that on Windows, this does CR/LF translation and _setmode() should
- // be used to change that if appropriate.
- return open(template_name, O_CREAT | O_EXCL | O_RDWR, S_IRUSR | S_IWUSR);
+ // Use O_BINARY to match base file APIs.
+ return open(template_name, O_CREAT | O_EXCL | O_RDWR | O_BINARY,
+ S_IRUSR | S_IWUSR);
}
char* mkdtemp(char* template_name) {