diff options
| author | Rafael Espindola <rafael.espindola@gmail.com> | 2015-06-24 19:57:32 +0000 |
|---|---|---|
| committer | Rafael Espindola <rafael.espindola@gmail.com> | 2015-06-24 19:57:32 +0000 |
| commit | a3af347f38956c1bb7a539c3af131c41fc2d2d01 (patch) | |
| tree | 6c0d4936480439667aada778426c8f97d446558a /tools/llvm-cxxdump | |
| parent | c9a4f3d5d9d46c84d23ec1e90b8b7aebcbb899f2 (diff) | |
Make computeSymbolSizes never fail.
On ELF that was already the case since getting the size of a symbol
never fails.
On MachO and COFF we could fail trying to get the section of a symbol. But
we don't really need the section, just the section number to know if two
symbols are in the same section or not.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@240580 91177308-0d34-0410-b5e6-96231b3b80d8
Diffstat (limited to 'tools/llvm-cxxdump')
| -rw-r--r-- | tools/llvm-cxxdump/llvm-cxxdump.cpp | 6 |
1 files changed, 2 insertions, 4 deletions
diff --git a/tools/llvm-cxxdump/llvm-cxxdump.cpp b/tools/llvm-cxxdump/llvm-cxxdump.cpp index bd9cf7d5df2..e4d32abb95c 100644 --- a/tools/llvm-cxxdump/llvm-cxxdump.cpp +++ b/tools/llvm-cxxdump/llvm-cxxdump.cpp @@ -188,12 +188,10 @@ static void dumpCXXData(const ObjectFile *Obj) { uint8_t BytesInAddress = Obj->getBytesInAddress(); - ErrorOr<std::vector<std::pair<SymbolRef, uint64_t>>> SymAddrOrErr = + std::vector<std::pair<SymbolRef, uint64_t>> SymAddr = object::computeSymbolSizes(*Obj); - if (error(SymAddrOrErr.getError())) - return; - for (auto &P : *SymAddrOrErr) { + for (auto &P : SymAddr) { object::SymbolRef Sym = P.first; uint64_t SymSize = P.second; StringRef SymName; |