diff options
| author | Dehao Chen <dehao@google.com> | 2017-09-19 21:18:14 +0000 |
|---|---|---|
| committer | Dehao Chen <dehao@google.com> | 2017-09-19 21:18:14 +0000 |
| commit | e536db08ac81c41f614ed1c5502d3abd023df376 (patch) | |
| tree | d7f115ce87d3123fb6b54cbfc38eddc2e49ee138 /test/Transforms/SampleProfile | |
| parent | cb6f3f43df332f9a425969f81e743bd330f9115b (diff) | |
Import all inlined indirect call targets for SamplePGO.
Summary: In the ThinLTO compilation, if a function is inlined in the profiling binary, we need to inline it before annotation. If the callee is not available in the primary module, a first step is needed to import that callee function. For the current implementation, if the call is an indirect call, which has been promoted to >1 targets and inlined, SamplePGO will only import one target with the largest sample count. This patch fixed the bug to import all targets instead.
Reviewers: tejohnson, davidxl
Reviewed By: tejohnson
Subscribers: sanjoy, llvm-commits, mehdi_amini
Differential Revision: https://reviews.llvm.org/D36637
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@313678 91177308-0d34-0410-b5e6-96231b3b80d8
Diffstat (limited to 'test/Transforms/SampleProfile')
| -rw-r--r-- | test/Transforms/SampleProfile/Inputs/import.prof | 6 | ||||
| -rw-r--r-- | test/Transforms/SampleProfile/import.ll | 16 |
2 files changed, 16 insertions, 6 deletions
diff --git a/test/Transforms/SampleProfile/Inputs/import.prof b/test/Transforms/SampleProfile/Inputs/import.prof index efadc0c5c9c..aae072ac191 100644 --- a/test/Transforms/SampleProfile/Inputs/import.prof +++ b/test/Transforms/SampleProfile/Inputs/import.prof @@ -1,4 +1,8 @@ -main:10000:0 +test:10000:0 3: foo:1000 3: bar:200 4: baz:10 + 4: foo1:1000 + 1: 1000 + 4: foo2:1000 + 1: 1000 diff --git a/test/Transforms/SampleProfile/import.ll b/test/Transforms/SampleProfile/import.ll index 1ee45fb4fd3..ad9c2d55aa9 100644 --- a/test/Transforms/SampleProfile/import.ll +++ b/test/Transforms/SampleProfile/import.ll @@ -5,14 +5,19 @@ declare void @foo() -define void @main() !dbg !7 { +define void @test(void ()*) !dbg !7 { + %2 = alloca void ()* + store void ()* %0, void ()** %2 + %3 = load void ()*, void ()** %2 + ; CHECK: call {{.*}}, !prof ![[PROF:[0-9]+]] call void @foo(), !dbg !18 + call void %3(), !dbg !19 ret void } -; GUIDs of foo and bar should be included in the metadata to make sure hot -; inline stacks are imported. -; CHECK: !{!"function_entry_count", i64 1, i64 6699318081062747564, i64 -2012135647395072713} +; GUIDs of foo, bar, foo1 and foo2 should be included in the metadata to make +; sure hot inline stacks are imported. +; CHECK: !{!"function_entry_count", i64 1, i64 2494702099028631698, i64 6699318081062747564, i64 7682762345278052905, i64 -2012135647395072713} !llvm.dbg.cu = !{!0} !llvm.module.flags = !{!8, !9} @@ -22,10 +27,11 @@ define void @main() !dbg !7 { !1 = !DIFile(filename: "calls.cc", directory: ".") !2 = !{} !6 = !DISubroutineType(types: !2) -!7 = distinct !DISubprogram(name: "main", line: 7, isLocal: false, isDefinition: true, virtualIndex: 6, flags: DIFlagPrototyped, isOptimized: false, unit: !0, scopeLine: 7, file: !1, scope: !1, type: !6, variables: !2) +!7 = distinct !DISubprogram(name: "test", line: 7, isLocal: false, isDefinition: true, virtualIndex: 6, flags: DIFlagPrototyped, isOptimized: false, unit: !0, scopeLine: 7, file: !1, scope: !1, type: !6, variables: !2) !8 = !{i32 2, !"Dwarf Version", i32 4} !9 = !{i32 1, !"Debug Info Version", i32 3} !10 = !{!"clang version 3.5 "} !15 = !DILexicalBlockFile(discriminator: 1, file: !1, scope: !7) !17 = distinct !DILexicalBlock(line: 10, column: 0, file: !1, scope: !7) !18 = !DILocation(line: 10, scope: !17) +!19 = !DILocation(line: 11, scope: !17) |