diff options
| author | Adrian Prantl <aprantl@apple.com> | 2016-12-20 02:09:43 +0000 |
|---|---|---|
| committer | Adrian Prantl <aprantl@apple.com> | 2016-12-20 02:09:43 +0000 |
| commit | 7b500b4bdf40cb40cb33bdcf5faf900db4930824 (patch) | |
| tree | 2c5863a671783389e2588110cfc880f301efdc35 /test/CodeGen/NVPTX | |
| parent | 23755c9509672822a2aeef123c89d64588586437 (diff) | |
[IR] Remove the DIExpression field from DIGlobalVariable.
This patch implements PR31013 by introducing a
DIGlobalVariableExpression that holds a pair of DIGlobalVariable and
DIExpression.
Currently, DIGlobalVariables holds a DIExpression. This is not the
best way to model this:
(1) The DIGlobalVariable should describe the source level variable,
not how to get to its location.
(2) It makes it unsafe/hard to update the expressions when we call
replaceExpression on the DIGLobalVariable.
(3) It makes it impossible to represent a global variable that is in
more than one location (e.g., a variable with multiple
DW_OP_LLVM_fragment-s). We also moved away from attaching the
DIExpression to DILocalVariable for the same reasons.
This reapplies r289902 with additional testcase upgrades and a change
to the Bitcode record for DIGlobalVariable, that makes upgrading the
old format unambiguous also for variables without DIExpressions.
<rdar://problem/29250149>
https://llvm.org/bugs/show_bug.cgi?id=31013
Differential Revision: https://reviews.llvm.org/D26769
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@290153 91177308-0d34-0410-b5e6-96231b3b80d8
Diffstat (limited to 'test/CodeGen/NVPTX')
| -rw-r--r-- | test/CodeGen/NVPTX/generic-to-nvvm-ir.ll | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/test/CodeGen/NVPTX/generic-to-nvvm-ir.ll b/test/CodeGen/NVPTX/generic-to-nvvm-ir.ll index 623a2d8740c..2bd946d01eb 100644 --- a/test/CodeGen/NVPTX/generic-to-nvvm-ir.ll +++ b/test/CodeGen/NVPTX/generic-to-nvvm-ir.ll @@ -42,10 +42,10 @@ declare void @extfunc(i8 signext) !3 = !{!4} ; Find list of global variables and make sure it's the one used by DICompileUnit ; CHECK: [[GLOBALSNODE]] = !{[[GVNODE:![0-9]+]]} -!4 = distinct !DIGlobalVariable(name: "static_var", scope: !0, file: !1, line: 2, type: !5, isLocal: false, - isDefinition: true) +!4 = !DIGlobalVariableExpression(var: !DIGlobalVariable(name: "static_var", scope: !0, file: !1, line: 2, type: !5, isLocal: false, isDefinition: true)) ; Debug info must also be updated to reflect new address space. -; CHECK: [[GVNODE]] = distinct !DIGlobalVariable(name: "static_var" +; CHECK: [[GVNODE]] = !DIGlobalVariableExpression(var: [[GVVAR:.*]]) +; CHECK: [[GVVAR]] = !DIGlobalVariable(name: "static_var" ; CHECK-SAME: scope: [[CUNODE]] ; CHECK-SAME: type: [[TYPENODE:![0-9]+]] !5 = !DIBasicType(name: "char", size: 8, align: 8, encoding: DW_ATE_signed_char) |