diff options
author | Tim Northover <tnorthover@apple.com> | 2016-04-13 23:08:27 +0000 |
---|---|---|
committer | Tim Northover <tnorthover@apple.com> | 2016-04-13 23:08:27 +0000 |
commit | 5a4800a05f83f12c3212a5494f9fb0c4ac13cd84 (patch) | |
tree | bda4d0cef9c75089f4df35b3d54ebf2fe1a982b4 /test/CodeGen/ARM/lsr-code-insertion.ll | |
parent | 609cf3b89c5070eca79cd3ea49fabf4a18cd8db9 (diff) |
ARM: override cost function to re-enable ConstantHoisting (& fix it).
At some point, ARM stopped getting any benefit from ConstantHoisting because
the pass called a different variant of getIntImmCost. Reimplementing the
correct variant revealed some problems, however:
+ ConstantHoisting was modifying switch statements. This is simply invalid,
the cases must remain integer constants no matter the notional cost.
+ ConstantHoisting was mangling alloca instructions in the entry block. These
should be handled by FrameLowering, so constants actually have a cost of 0.
Worse, the resulting bitcasts meant they became dynamic allocas.
rdar://25707382
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@266260 91177308-0d34-0410-b5e6-96231b3b80d8
Diffstat (limited to 'test/CodeGen/ARM/lsr-code-insertion.ll')
-rw-r--r-- | test/CodeGen/ARM/lsr-code-insertion.ll | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/test/CodeGen/ARM/lsr-code-insertion.ll b/test/CodeGen/ARM/lsr-code-insertion.ll index aa2b2d26d12..766710fd1d6 100644 --- a/test/CodeGen/ARM/lsr-code-insertion.ll +++ b/test/CodeGen/ARM/lsr-code-insertion.ll @@ -9,8 +9,8 @@ ; ; CHECK: ldr [[R6:r[0-9*]+]], LCP ; CHECK: cmp {{.*}}, [[R6]] -; CHECK: ldrle -; CHECK-NEXT: strle +; CHECK-NOT: lt +; CHECK: strlt target triple = "arm-apple-darwin8" |