diff options
author | Tim Northover <tnorthover@apple.com> | 2017-12-18 10:36:00 +0000 |
---|---|---|
committer | Tim Northover <tnorthover@apple.com> | 2017-12-18 10:36:00 +0000 |
commit | f66f36e9a4d53da8801a673a78c6ed42c838d37b (patch) | |
tree | b8150d4a25f27ccd8c4a937ee1189429ff185a57 /test/CodeGen/AArch64 | |
parent | b887495d4b1c3c9e168566e6c09f03ff80de930d (diff) |
AArch64: work around how Cyclone handles "movi.2d vD, #0".
For Cylone, the instruction "movi.2d vD, #0" is executed incorrectly in some rare
circumstances. Work around the issue conservatively by avoiding the instruction entirely.
This patch changes CodeGen so that problematic instructions are never
generated, and the AsmParser so that an equivalent instruction is used (with a
warning).
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@320965 91177308-0d34-0410-b5e6-96231b3b80d8
Diffstat (limited to 'test/CodeGen/AArch64')
-rw-r--r-- | test/CodeGen/AArch64/arm64-fcmp-opt.ll | 28 | ||||
-rw-r--r-- | test/CodeGen/AArch64/arm64-zero-cycle-zeroing.ll | 12 | ||||
-rw-r--r-- | test/CodeGen/AArch64/fp-cond-sel.ll | 2 |
3 files changed, 21 insertions, 21 deletions
diff --git a/test/CodeGen/AArch64/arm64-fcmp-opt.ll b/test/CodeGen/AArch64/arm64-fcmp-opt.ll index e8b1557bac6..5155d49cc3f 100644 --- a/test/CodeGen/AArch64/arm64-fcmp-opt.ll +++ b/test/CodeGen/AArch64/arm64-fcmp-opt.ll @@ -41,7 +41,7 @@ entry: define float @fcmp_oeq(float %a, float %b) nounwind ssp { ; CHECK-LABEL: @fcmp_oeq ; CHECK: fcmp s0, s1 -; CHECK-DAG: movi.2d v[[ZERO:[0-9]+]], #0 +; CHECK-DAG: fmov s[[ZERO:[0-9]+]], wzr ; CHECK-DAG: fmov s[[ONE:[0-9]+]], #1.0 ; CHECK: fcsel s0, s[[ONE]], s[[ZERO]], eq @@ -53,7 +53,7 @@ define float @fcmp_oeq(float %a, float %b) nounwind ssp { define float @fcmp_ogt(float %a, float %b) nounwind ssp { ; CHECK-LABEL: @fcmp_ogt ; CHECK: fcmp s0, s1 -; CHECK-DAG: movi.2d v[[ZERO:[0-9]+]], #0 +; CHECK-DAG: fmov s[[ZERO:[0-9]+]], wzr ; CHECK-DAG: fmov s[[ONE:[0-9]+]], #1.0 ; CHECK: fcsel s0, s[[ONE]], s[[ZERO]], gt @@ -65,7 +65,7 @@ define float @fcmp_ogt(float %a, float %b) nounwind ssp { define float @fcmp_oge(float %a, float %b) nounwind ssp { ; CHECK-LABEL: @fcmp_oge ; CHECK: fcmp s0, s1 -; CHECK-DAG: movi.2d v[[ZERO:[0-9]+]], #0 +; CHECK-DAG: fmov s[[ZERO:[0-9]+]], wzr ; CHECK-DAG: fmov s[[ONE:[0-9]+]], #1.0 ; CHECK: fcsel s0, s[[ONE]], s[[ZERO]], ge @@ -77,7 +77,7 @@ define float @fcmp_oge(float %a, float %b) nounwind ssp { define float @fcmp_olt(float %a, float %b) nounwind ssp { ; CHECK-LABEL: @fcmp_olt ; CHECK: fcmp s0, s1 -; CHECK-DAG: movi.2d v[[ZERO:[0-9]+]], #0 +; CHECK-DAG: fmov s[[ZERO:[0-9]+]], wzr ; CHECK-DAG: fmov s[[ONE:[0-9]+]], #1.0 ; CHECK: fcsel s0, s[[ONE]], s[[ZERO]], mi @@ -89,7 +89,7 @@ define float @fcmp_olt(float %a, float %b) nounwind ssp { define float @fcmp_ole(float %a, float %b) nounwind ssp { ; CHECK-LABEL: @fcmp_ole ; CHECK: fcmp s0, s1 -; CHECK-DAG: movi.2d v[[ZERO:[0-9]+]], #0 +; CHECK-DAG: fmov s[[ZERO:[0-9]+]], wzr ; CHECK-DAG: fmov s[[ONE:[0-9]+]], #1.0 ; CHECK: fcsel s0, s[[ONE]], s[[ZERO]], ls @@ -101,7 +101,7 @@ define float @fcmp_ole(float %a, float %b) nounwind ssp { define float @fcmp_ord(float %a, float %b) nounwind ssp { ; CHECK-LABEL: @fcmp_ord ; CHECK: fcmp s0, s1 -; CHECK-DAG: movi.2d v[[ZERO:[0-9]+]], #0 +; CHECK-DAG: fmov s[[ZERO:[0-9]+]], wzr ; CHECK-DAG: fmov s[[ONE:[0-9]+]], #1.0 ; CHECK: fcsel s0, s[[ONE]], s[[ZERO]], vc %cmp = fcmp ord float %a, %b @@ -112,7 +112,7 @@ define float @fcmp_ord(float %a, float %b) nounwind ssp { define float @fcmp_uno(float %a, float %b) nounwind ssp { ; CHECK-LABEL: @fcmp_uno ; CHECK: fcmp s0, s1 -; CHECK-DAG: movi.2d v[[ZERO:[0-9]+]], #0 +; CHECK-DAG: fmov s[[ZERO:[0-9]+]], wzr ; CHECK-DAG: fmov s[[ONE:[0-9]+]], #1.0 ; CHECK: fcsel s0, s[[ONE]], s[[ZERO]], vs %cmp = fcmp uno float %a, %b @@ -123,7 +123,7 @@ define float @fcmp_uno(float %a, float %b) nounwind ssp { define float @fcmp_ugt(float %a, float %b) nounwind ssp { ; CHECK-LABEL: @fcmp_ugt ; CHECK: fcmp s0, s1 -; CHECK-DAG: movi.2d v[[ZERO:[0-9]+]], #0 +; CHECK-DAG: fmov s[[ZERO:[0-9]+]], wzr ; CHECK-DAG: fmov s[[ONE:[0-9]+]], #1.0 ; CHECK: fcsel s0, s[[ONE]], s[[ZERO]], hi %cmp = fcmp ugt float %a, %b @@ -134,7 +134,7 @@ define float @fcmp_ugt(float %a, float %b) nounwind ssp { define float @fcmp_uge(float %a, float %b) nounwind ssp { ; CHECK-LABEL: @fcmp_uge ; CHECK: fcmp s0, s1 -; CHECK-DAG: movi.2d v[[ZERO:[0-9]+]], #0 +; CHECK-DAG: fmov s[[ZERO:[0-9]+]], wzr ; CHECK-DAG: fmov s[[ONE:[0-9]+]], #1.0 ; CHECK: fcsel s0, s[[ONE]], s[[ZERO]], pl %cmp = fcmp uge float %a, %b @@ -145,7 +145,7 @@ define float @fcmp_uge(float %a, float %b) nounwind ssp { define float @fcmp_ult(float %a, float %b) nounwind ssp { ; CHECK-LABEL: @fcmp_ult ; CHECK: fcmp s0, s1 -; CHECK-DAG: movi.2d v[[ZERO:[0-9]+]], #0 +; CHECK-DAG: fmov s[[ZERO:[0-9]+]], wzr ; CHECK-DAG: fmov s[[ONE:[0-9]+]], #1.0 ; CHECK: fcsel s0, s[[ONE]], s[[ZERO]], lt %cmp = fcmp ult float %a, %b @@ -156,7 +156,7 @@ define float @fcmp_ult(float %a, float %b) nounwind ssp { define float @fcmp_ule(float %a, float %b) nounwind ssp { ; CHECK-LABEL: @fcmp_ule ; CHECK: fcmp s0, s1 -; CHECK-DAG: movi.2d v[[ZERO:[0-9]+]], #0 +; CHECK-DAG: fmov s[[ZERO:[0-9]+]], wzr ; CHECK-DAG: fmov s[[ONE:[0-9]+]], #1.0 ; CHECK: fcsel s0, s[[ONE]], s[[ZERO]], le %cmp = fcmp ule float %a, %b @@ -167,7 +167,7 @@ define float @fcmp_ule(float %a, float %b) nounwind ssp { define float @fcmp_une(float %a, float %b) nounwind ssp { ; CHECK-LABEL: @fcmp_une ; CHECK: fcmp s0, s1 -; CHECK-DAG: movi.2d v[[ZERO:[0-9]+]], #0 +; CHECK-DAG: fmov s[[ZERO:[0-9]+]], wzr ; CHECK-DAG: fmov s[[ONE:[0-9]+]], #1.0 ; CHECK: fcsel s0, s[[ONE]], s[[ZERO]], ne %cmp = fcmp une float %a, %b @@ -180,7 +180,7 @@ define float @fcmp_une(float %a, float %b) nounwind ssp { define float @fcmp_one(float %a, float %b) nounwind ssp { ; CHECK-LABEL: @fcmp_one ; fcmp s0, s1 -; CHECK-DAG: movi.2d v[[ZERO:[0-9]+]], #0 +; CHECK-DAG: fmov s[[ZERO:[0-9]+]], wzr ; CHECK-DAG: fmov s[[ONE:[0-9]+]], #1.0 ; CHECK: fcsel [[TMP:s[0-9]+]], s[[ONE]], s[[ZERO]], mi ; CHECK: fcsel s0, s[[ONE]], [[TMP]], gt @@ -194,7 +194,7 @@ define float @fcmp_one(float %a, float %b) nounwind ssp { define float @fcmp_ueq(float %a, float %b) nounwind ssp { ; CHECK-LABEL: @fcmp_ueq ; CHECK: fcmp s0, s1 -; CHECK-DAG: movi.2d v[[ZERO:[0-9]+]], #0 +; CHECK-DAG: fmov s[[ZERO:[0-9]+]], wzr ; CHECK-DAG: fmov s[[ONE:[0-9]+]], #1.0 ; CHECK: fcsel [[TMP:s[0-9]+]], s[[ONE]], s[[ZERO]], eq ; CHECK: fcsel s0, s[[ONE]], [[TMP]], vs diff --git a/test/CodeGen/AArch64/arm64-zero-cycle-zeroing.ll b/test/CodeGen/AArch64/arm64-zero-cycle-zeroing.ll index 412651c5567..453334dce60 100644 --- a/test/CodeGen/AArch64/arm64-zero-cycle-zeroing.ll +++ b/test/CodeGen/AArch64/arm64-zero-cycle-zeroing.ll @@ -9,10 +9,10 @@ define void @t1() nounwind ssp { entry: ; ALL-LABEL: t1: ; ALL-NOT: fmov -; CYCLONE: movi.2d v0, #0000000000000000 -; CYCLONE: movi.2d v1, #0000000000000000 -; CYCLONE: movi.2d v2, #0000000000000000 -; CYCLONE: movi.2d v3, #0000000000000000 +; CYCLONE: fmov d0, xzr +; CYCLONE: fmov d1, xzr +; CYCLONE: fmov d2, xzr +; CYCLONE: fmov d3, xzr ; KRYO: movi v0.2d, #0000000000000000 ; KRYO: movi v1.2d, #0000000000000000 ; KRYO: movi v2.2d, #0000000000000000 @@ -48,8 +48,8 @@ entry: define void @t4() nounwind ssp { ; ALL-LABEL: t4: ; ALL-NOT: fmov -; CYCLONE: movi.2d v0, #0000000000000000 -; CYCLONE: movi.2d v1, #0000000000000000 +; CYCLONE: fmov s0, wzr +; CYCLONE: fmov s1, wzr ; KRYO: movi v0.2d, #0000000000000000 ; KRYO: movi v1.2d, #0000000000000000 ; FALKOR: movi v0.2d, #0000000000000000 diff --git a/test/CodeGen/AArch64/fp-cond-sel.ll b/test/CodeGen/AArch64/fp-cond-sel.ll index 4d9cb21ddc3..f74e9c35094 100644 --- a/test/CodeGen/AArch64/fp-cond-sel.ll +++ b/test/CodeGen/AArch64/fp-cond-sel.ll @@ -12,7 +12,7 @@ define void @test_csel(i32 %lhs32, i32 %rhs32, i64 %lhs64) { %tst1 = icmp ugt i32 %lhs32, %rhs32 %val1 = select i1 %tst1, float 0.0, float 1.0 store float %val1, float* @varfloat -; CHECK-DAG: movi v[[FLT0:[0-9]+]].2d, #0 +; CHECK-DAG: fmov s[[FLT0:[0-9]+]], wzr ; CHECK-DAG: fmov s[[FLT1:[0-9]+]], #1.0 ; CHECK: fcsel {{s[0-9]+}}, s[[FLT0]], s[[FLT1]], hi |