summaryrefslogtreecommitdiff
path: root/lib
diff options
context:
space:
mode:
authorAhmed Bougacha <ahmed.bougacha@gmail.com>2016-08-02 16:17:15 +0000
committerAhmed Bougacha <ahmed.bougacha@gmail.com>2016-08-02 16:17:15 +0000
commit1f82c34de8c1a5feff27a8b3e6a1414fd987fa8c (patch)
tree7998494dd593c582f3d742e819c295ba53462d9f /lib
parent31c3e4f36316f677bf33f2a976bd39290e7deb50 (diff)
[GlobalISel] Verify RegBankSelected MF property.
RegBankSelected functions shouldn't have any generic virtual register not assigned to a bank. Verify that. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@277476 91177308-0d34-0410-b5e6-96231b3b80d8
Diffstat (limited to 'lib')
-rw-r--r--lib/CodeGen/MachineVerifier.cpp18
1 files changed, 17 insertions, 1 deletions
diff --git a/lib/CodeGen/MachineVerifier.cpp b/lib/CodeGen/MachineVerifier.cpp
index 8c45ce2648a..9161cda5184 100644
--- a/lib/CodeGen/MachineVerifier.cpp
+++ b/lib/CodeGen/MachineVerifier.cpp
@@ -70,6 +70,9 @@ namespace {
unsigned foundErrors;
+ // Avoid querying the MachineFunctionProperties for each operand.
+ bool isFunctionRegBankSelected;
+
typedef SmallVector<unsigned, 16> RegVector;
typedef SmallVector<const uint32_t*, 4> RegMaskVector;
typedef DenseSet<unsigned> RegSet;
@@ -330,6 +333,9 @@ unsigned MachineVerifier::verify(MachineFunction &MF) {
TRI = MF.getSubtarget().getRegisterInfo();
MRI = &MF.getRegInfo();
+ isFunctionRegBankSelected = MF.getProperties().hasProperty(
+ MachineFunctionProperties::Property::RegBankSelected);
+
LiveVars = nullptr;
LiveInts = nullptr;
LiveStks = nullptr;
@@ -1003,8 +1009,18 @@ MachineVerifier::visitMachineOperand(const MachineOperand *MO, unsigned MONum) {
report("Generic virtual register must have a size", MO, MONum);
return;
}
- // Make sure the register fits into its register bank if any.
+
const RegisterBank *RegBank = MRI->getRegBankOrNull(Reg);
+
+ // If we're post-RegBankSelect, the gvreg must have a bank.
+ if (!RegBank && isFunctionRegBankSelected) {
+ report("Generic virtual register must have a bank in a "
+ "RegBankSelected function",
+ MO, MONum);
+ return;
+ }
+
+ // Make sure the register fits into its register bank if any.
if (RegBank && RegBank->getSize() < Size) {
report("Register bank is too small for virtual register", MO,
MONum);