diff options
author | Matthias Braun <matze@braunis.de> | 2017-01-28 02:02:38 +0000 |
---|---|---|
committer | Matthias Braun <matze@braunis.de> | 2017-01-28 02:02:38 +0000 |
commit | 88d207542b618ca6054b24491ddd67f8ca397540 (patch) | |
tree | f62acd2207c3b8c726f2b30d9501355613c092c3 /lib/Option | |
parent | 92cf58ee368511a9ef8a97cd7ff2702effcc745c (diff) |
Cleanup dump() functions.
We had various variants of defining dump() functions in LLVM. Normalize
them (this should just consistently implement the things discussed in
http://lists.llvm.org/pipermail/cfe-dev/2014-January/034323.html
For reference:
- Public headers should just declare the dump() method but not use
LLVM_DUMP_METHOD or #if !defined(NDEBUG) || defined(LLVM_ENABLE_DUMP)
- The definition of a dump method should look like this:
#if !defined(NDEBUG) || defined(LLVM_ENABLE_DUMP)
LLVM_DUMP_METHOD void MyClass::dump() {
// print stuff to dbgs()...
}
#endif
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@293359 91177308-0d34-0410-b5e6-96231b3b80d8
Diffstat (limited to 'lib/Option')
-rw-r--r-- | lib/Option/Arg.cpp | 2 | ||||
-rw-r--r-- | lib/Option/ArgList.cpp | 2 | ||||
-rw-r--r-- | lib/Option/Option.cpp | 2 |
3 files changed, 6 insertions, 0 deletions
diff --git a/lib/Option/Arg.cpp b/lib/Option/Arg.cpp index c3de2d1a496..3e8a1d80231 100644 --- a/lib/Option/Arg.cpp +++ b/lib/Option/Arg.cpp @@ -61,7 +61,9 @@ void Arg::print(raw_ostream& O) const { O << "]>\n"; } +#if !defined(NDEBUG) || defined(LLVM_ENABLE_DUMP) LLVM_DUMP_METHOD void Arg::dump() const { print(dbgs()); } +#endif std::string Arg::getAsString(const ArgList &Args) const { SmallString<256> Res; diff --git a/lib/Option/ArgList.cpp b/lib/Option/ArgList.cpp index f94de866ef3..7ff358a57e0 100644 --- a/lib/Option/ArgList.cpp +++ b/lib/Option/ArgList.cpp @@ -353,7 +353,9 @@ void ArgList::print(raw_ostream &O) const { } } +#if !defined(NDEBUG) || defined(LLVM_ENABLE_DUMP) LLVM_DUMP_METHOD void ArgList::dump() const { print(dbgs()); } +#endif // diff --git a/lib/Option/Option.cpp b/lib/Option/Option.cpp index 5eb179fbd25..736b939fe80 100644 --- a/lib/Option/Option.cpp +++ b/lib/Option/Option.cpp @@ -83,7 +83,9 @@ void Option::print(raw_ostream &O) const { O << ">\n"; } +#if !defined(NDEBUG) || defined(LLVM_ENABLE_DUMP) LLVM_DUMP_METHOD void Option::dump() const { print(dbgs()); } +#endif bool Option::matches(OptSpecifier Opt) const { // Aliases are never considered in matching, look through them. |