diff options
author | Oliver Stannard <oliver.stannard@arm.com> | 2017-08-21 09:58:37 +0000 |
---|---|---|
committer | Oliver Stannard <oliver.stannard@arm.com> | 2017-08-21 09:58:37 +0000 |
commit | e8fad78d5a5dc76648fbffdfec5d9cb8ea38c7cf (patch) | |
tree | 1642b2c04dc8b47860adf6351b32d20b202c647b /lib/MC/MCParser | |
parent | 7c7e6bed7bf1be3e5ce1a94909d67a4dc7eb300d (diff) |
[AsmParser] Recommit: Hash is not a comment on some targets
Re-committing after r311325 fixed an unintentional use of '#' comments in
clang.
The '#' token is not a comment for all targets (on ARM and AArch64 it marks an
immediate operand), so we shouldn't treat it as such.
Comments are already converted to AsmToken::EndOfStatement by
AsmLexer::LexLineComment, so this check was unnecessary.
Differential Revision: https://reviews.llvm.org/D36405
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@311326 91177308-0d34-0410-b5e6-96231b3b80d8
Diffstat (limited to 'lib/MC/MCParser')
-rw-r--r-- | lib/MC/MCParser/AsmParser.cpp | 10 | ||||
-rw-r--r-- | lib/MC/MCParser/MCAsmParser.cpp | 8 |
2 files changed, 0 insertions, 18 deletions
diff --git a/lib/MC/MCParser/AsmParser.cpp b/lib/MC/MCParser/AsmParser.cpp index a75476d2298..b0f6a4cd501 100644 --- a/lib/MC/MCParser/AsmParser.cpp +++ b/lib/MC/MCParser/AsmParser.cpp @@ -1648,16 +1648,6 @@ bool AsmParser::parseStatement(ParseStatementInfo &Info, Lex(); return false; } - if (Lexer.is(AsmToken::Hash)) { - // Seeing a hash here means that it was an end-of-line comment in - // an asm syntax where hash's are not comment and the previous - // statement parser did not check the end of statement. Relex as - // EndOfStatement. - StringRef CommentStr = parseStringToEndOfStatement(); - Lexer.Lex(); - Lexer.UnLex(AsmToken(AsmToken::EndOfStatement, CommentStr)); - return false; - } // Statements always start with an identifier. AsmToken ID = getTok(); SMLoc IDLoc = ID.getLoc(); diff --git a/lib/MC/MCParser/MCAsmParser.cpp b/lib/MC/MCParser/MCAsmParser.cpp index ea36b3b9b3b..6a4c74cd57f 100644 --- a/lib/MC/MCParser/MCAsmParser.cpp +++ b/lib/MC/MCParser/MCAsmParser.cpp @@ -40,11 +40,6 @@ bool MCAsmParser::parseTokenLoc(SMLoc &Loc) { } bool MCAsmParser::parseEOL(const Twine &Msg) { - if (getTok().getKind() == AsmToken::Hash) { - StringRef CommentStr = parseStringToEndOfStatement(); - getLexer().Lex(); - getLexer().UnLex(AsmToken(AsmToken::EndOfStatement, CommentStr)); - } if (getTok().getKind() != AsmToken::EndOfStatement) return Error(getTok().getLoc(), Msg); Lex(); @@ -70,9 +65,6 @@ bool MCAsmParser::parseIntToken(int64_t &V, const Twine &Msg) { bool MCAsmParser::parseOptionalToken(AsmToken::TokenKind T) { bool Present = (getTok().getKind() == T); - // if token is EOL and current token is # this is an EOL comment. - if (getTok().getKind() == AsmToken::Hash && T == AsmToken::EndOfStatement) - Present = true; if (Present) parseToken(T); return Present; |