diff options
| author | Peter Collingbourne <peter@pcc.me.uk> | 2017-09-07 00:55:00 +0000 |
|---|---|---|
| committer | Peter Collingbourne <peter@pcc.me.uk> | 2017-09-07 00:55:00 +0000 |
| commit | d91746fb9e8691ce22ad3da4c78d451836a10e80 (patch) | |
| tree | 00de837e96336284accdb9ae9de38542a6c5c0e2 /lib/LTO | |
| parent | c97f51f04bf2d31ace2dd76c9d2520a14352a6bb (diff) | |
LTO: Remove unnecessary Windows support code.
I empirically verified that open files can in fact be renamed on
Windows with sys::fs::rename, so remove the incorrect code and comment.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@312683 91177308-0d34-0410-b5e6-96231b3b80d8
Diffstat (limited to 'lib/LTO')
| -rw-r--r-- | lib/LTO/Caching.cpp | 15 |
1 files changed, 0 insertions, 15 deletions
diff --git a/lib/LTO/Caching.cpp b/lib/LTO/Caching.cpp index 3f10c154683..98360f7e9e9 100644 --- a/lib/LTO/Caching.cpp +++ b/lib/LTO/Caching.cpp @@ -63,20 +63,6 @@ Expected<NativeObjectCache> lto::localCache(StringRef CacheDirectoryPath, // Make sure the file is closed before committing it. OS.reset(); -#ifdef _WIN32 - // Rename the file first on Windows because we cannot rename an open - // file on that platform using the sys::fs::rename function. - // FIXME: This code could race with the cache pruner, but it is unlikely - // that the cache pruner will choose to remove a newly created file. - // We should look at using the SetFileInformationByHandle function to - // rename the file while it is open. - if (auto EC = sys::fs::rename(TempFilename, EntryPath)) - report_fatal_error(Twine("Failed to rename temporary file ") + - TempFilename + ": " + EC.message() + "\n"); - - ErrorOr<std::unique_ptr<MemoryBuffer>> MBOrErr = - MemoryBuffer::getFile(EntryPath); -#else // Open the file first to avoid racing with a cache pruner. ErrorOr<std::unique_ptr<MemoryBuffer>> MBOrErr = MemoryBuffer::getFile(TempFilename); @@ -85,7 +71,6 @@ Expected<NativeObjectCache> lto::localCache(StringRef CacheDirectoryPath, if (auto EC = sys::fs::rename(TempFilename, EntryPath)) report_fatal_error(Twine("Failed to rename temporary file ") + TempFilename + ": " + EC.message() + "\n"); -#endif if (!MBOrErr) report_fatal_error(Twine("Failed to open cache file ") + EntryPath + |