diff options
author | Chandler Carruth <chandlerc@gmail.com> | 2014-03-04 09:00:15 +0000 |
---|---|---|
committer | Chandler Carruth <chandlerc@gmail.com> | 2014-03-04 09:00:15 +0000 |
commit | 775581c4181c7f5ef36258788ae19d6346d3f0ec (patch) | |
tree | 5b1f5995ddcf189275dd6d763d6b9bb17e2eed5e /lib/IR/Use.cpp | |
parent | 4f6b2a26dae747fd4cce1a5a1e41fdb58e787cd4 (diff) |
[cleanup] Use early exit and simpler temporary variables to clarify the
swap implementation.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@202802 91177308-0d34-0410-b5e6-96231b3b80d8
Diffstat (limited to 'lib/IR/Use.cpp')
-rw-r--r-- | lib/IR/Use.cpp | 37 |
1 files changed, 18 insertions, 19 deletions
diff --git a/lib/IR/Use.cpp b/lib/IR/Use.cpp index b6720e56764..5f01e238e04 100644 --- a/lib/IR/Use.cpp +++ b/lib/IR/Use.cpp @@ -14,27 +14,26 @@ namespace llvm { void Use::swap(Use &RHS) { - Value *V1(Val); - Value *V2(RHS.Val); - if (V1 != V2) { - if (V1) { - removeFromList(); - } + if (Val == RHS.Val) + return; - if (V2) { - RHS.removeFromList(); - Val = V2; - V2->addUse(*this); - } else { - Val = 0; - } + if (Val) + removeFromList(); - if (V1) { - RHS.Val = V1; - V1->addUse(RHS); - } else { - RHS.Val = 0; - } + Value *OldVal = Val; + if (RHS.Val) { + RHS.removeFromList(); + Val = RHS.Val; + Val->addUse(*this); + } else { + Val = 0; + } + + if (OldVal) { + RHS.Val = OldVal; + RHS.Val->addUse(RHS); + } else { + RHS.Val = 0; } } |