diff options
author | Andres Freund <andres@anarazel.de> | 2018-05-24 05:10:19 +0000 |
---|---|---|
committer | Andres Freund <andres@anarazel.de> | 2018-05-24 05:10:19 +0000 |
commit | 017f7dfd701c4f6fc205b029c51d71300d17877b (patch) | |
tree | 08ccc5c0274ddb3109d6d55ed690350d18f7ee3d /lib/ExecutionEngine/Orc | |
parent | b0bd4049744f336edf77596ed85a69f771f1f054 (diff) |
Revert r333147 "[ORC] Add findSymbolIn() wrapper to C bindings."
This reverts r333147 until https://reviews.llvm.org/D47308 is ready to
be reviewed. r333147 exposed a behavioural difference between
OrcCBindingsStack::findSymbolIn() and OrcCBindingsStack::findSymbol(),
where only the latter does name mangling. After r333147 that causes a
test failure on OSX, because the new test looks for main using
findSymbolIn() but the mangled name is _main.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@333152 91177308-0d34-0410-b5e6-96231b3b80d8
Diffstat (limited to 'lib/ExecutionEngine/Orc')
-rw-r--r-- | lib/ExecutionEngine/Orc/OrcCBindings.cpp | 8 | ||||
-rw-r--r-- | lib/ExecutionEngine/Orc/OrcCBindingsStack.h | 22 |
2 files changed, 0 insertions, 30 deletions
diff --git a/lib/ExecutionEngine/Orc/OrcCBindings.cpp b/lib/ExecutionEngine/Orc/OrcCBindings.cpp index 1cf8a3a745a..0ea7a663989 100644 --- a/lib/ExecutionEngine/Orc/OrcCBindings.cpp +++ b/lib/ExecutionEngine/Orc/OrcCBindings.cpp @@ -112,14 +112,6 @@ LLVMOrcErrorCode LLVMOrcGetSymbolAddress(LLVMOrcJITStackRef JITStack, return J.findSymbolAddress(*RetAddr, SymbolName, true); } -LLVMOrcErrorCode LLVMOrcGetSymbolAddressIn(LLVMOrcJITStackRef JITStack, - LLVMOrcTargetAddress *RetAddr, - LLVMOrcModuleHandle H, - const char *SymbolName) { - OrcCBindingsStack &J = *unwrap(JITStack); - return J.findSymbolAddressIn(*RetAddr, H, SymbolName, true); -} - LLVMOrcErrorCode LLVMOrcDisposeInstance(LLVMOrcJITStackRef JITStack) { auto *J = unwrap(JITStack); auto Err = J->shutdown(); diff --git a/lib/ExecutionEngine/Orc/OrcCBindingsStack.h b/lib/ExecutionEngine/Orc/OrcCBindingsStack.h index a2e866c3ab7..5af5e6a3a49 100644 --- a/lib/ExecutionEngine/Orc/OrcCBindingsStack.h +++ b/lib/ExecutionEngine/Orc/OrcCBindingsStack.h @@ -380,7 +380,6 @@ public: JITSymbol findSymbolIn(orc::VModuleKey K, const std::string &Name, bool ExportedSymbolsOnly) { - assert(KeyLayers.count(K) && "looking up symbol in unknown module"); return KeyLayers[K]->findSymbolIn(K, Name, ExportedSymbolsOnly); } @@ -404,27 +403,6 @@ public: return LLVMOrcErrSuccess; } - LLVMOrcErrorCode findSymbolAddressIn(JITTargetAddress &RetAddr, - orc::VModuleKey K, - const std::string &Name, - bool ExportedSymbolsOnly) { - RetAddr = 0; - if (auto Sym = findSymbolIn(K, Name, ExportedSymbolsOnly)) { - // Successful lookup, non-null symbol: - if (auto AddrOrErr = Sym.getAddress()) { - RetAddr = *AddrOrErr; - return LLVMOrcErrSuccess; - } else - return mapError(AddrOrErr.takeError()); - } else if (auto Err = Sym.takeError()) { - // Lookup failure - report error. - return mapError(std::move(Err)); - } - // Otherwise we had a successful lookup but got a null result. We already - // set RetAddr to '0' above, so just return success. - return LLVMOrcErrSuccess; - } - const std::string &getErrorMessage() const { return ErrMsg; } private: |