diff options
| author | Oleg Ranevskyy <oranevskyy@accesssoftek.com> | 2017-08-10 13:37:58 +0000 |
|---|---|---|
| committer | Oleg Ranevskyy <oranevskyy@accesssoftek.com> | 2017-08-10 13:37:58 +0000 |
| commit | fc65759fdfe560394d5dfea71f0952d7b85d9ec1 (patch) | |
| tree | 3c8dbfd2cc6c5b56843445c01005134714fd4fd7 /cmake | |
| parent | 5d7c8961da260626a389dc9dcb6bbbd5f3119070 (diff) | |
[CMake][LLVM] Remove duplicated library mask. Broken clang linking against clangShared
Summary:
The `LLVM${c}Info` mask is listed twice in LLVM-Config.cmake. This results in the libraries such as LLVMARMInfo, LLVMAArch4Info, etc appearing twice in `extract_symbols.py` command line while building `clangShared`. `Extract_symbols.py` does not work well in such a case and completely ignores the symbols from the duplicated libraries. Thus, the LLVM(...)Info symbols do not get exported from `clangShared` and linking clang against it fails with unresolved dependencies.
Seems to be a mere copy-paste mistake.
Reviewers: beanz, chapuni
Reviewed By: chapuni
Subscribers: chapuni, aemerson, mgorny, kristof.beyls, llvm-commits, asl
Differential Revision: https://reviews.llvm.org/D36119
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@310590 91177308-0d34-0410-b5e6-96231b3b80d8
Diffstat (limited to 'cmake')
| -rw-r--r-- | cmake/modules/LLVM-Config.cmake | 9 |
1 files changed, 3 insertions, 6 deletions
diff --git a/cmake/modules/LLVM-Config.cmake b/cmake/modules/LLVM-Config.cmake index 52330151065..2b9ab23c477 100644 --- a/cmake/modules/LLVM-Config.cmake +++ b/cmake/modules/LLVM-Config.cmake @@ -175,18 +175,15 @@ function(llvm_map_components_to_libnames out_libs) message(FATAL_ERROR "Target ${c} is not in the set of libraries.") endif() endif() - if( TARGET LLVM${c}AsmPrinter ) - list(APPEND expanded_components "LLVM${c}AsmPrinter") - endif() if( TARGET LLVM${c}AsmParser ) list(APPEND expanded_components "LLVM${c}AsmParser") endif() + if( TARGET LLVM${c}AsmPrinter ) + list(APPEND expanded_components "LLVM${c}AsmPrinter") + endif() if( TARGET LLVM${c}Desc ) list(APPEND expanded_components "LLVM${c}Desc") endif() - if( TARGET LLVM${c}Info ) - list(APPEND expanded_components "LLVM${c}Info") - endif() if( TARGET LLVM${c}Disassembler ) list(APPEND expanded_components "LLVM${c}Disassembler") endif() |