diff options
| author | Shoaib Meenai <smeenai@fb.com> | 2017-12-14 18:41:49 +0000 |
|---|---|---|
| committer | Shoaib Meenai <smeenai@fb.com> | 2017-12-14 18:41:49 +0000 |
| commit | 18fcbf52eb51eeb6d220eb5a7a7858c42b2d6cf3 (patch) | |
| tree | 5783b8790382bdc24bdbd82e028e395ae4abbc67 /cmake | |
| parent | f74c3ebbfb48f6b54de0a19947cdefc583a83de1 (diff) | |
[cmake] Only attempt to install MSVC system libraries on Windows
Newer versions of CMake (I'm on 3.10, but I believe 3.9 behaves the same
way) attempt to query the system for information about the VS 2017
install. Unfortunately, this query fails on non-Windows systems:
cmake_host_system_information does not recognize <key> VS_15_DIR
CMake isn't going to find these system libraries on non-Windows anyway
(and we were previously silencing the resultant warnings in our
cross-compilation toolchain), so it makes sense to just omit the
attempted installation entirely on non-Windows.
Differential Revision: https://reviews.llvm.org/D41220
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@320724 91177308-0d34-0410-b5e6-96231b3b80d8
Diffstat (limited to 'cmake')
| -rw-r--r-- | cmake/platforms/WinMsvc.cmake | 7 |
1 files changed, 0 insertions, 7 deletions
diff --git a/cmake/platforms/WinMsvc.cmake b/cmake/platforms/WinMsvc.cmake index 5fd0c95af04..c4761636c92 100644 --- a/cmake/platforms/WinMsvc.cmake +++ b/cmake/platforms/WinMsvc.cmake @@ -299,10 +299,3 @@ set(CMAKE_SHARED_LINKER_FLAGS "${_CMAKE_SHARED_LINKER_FLAGS_INITIAL} ${LINK_FLAG # control which libraries they require. set(CMAKE_C_STANDARD_LIBRARIES "" CACHE STRING "" FORCE) set(CMAKE_CXX_STANDARD_LIBRARIES "" CACHE STRING "" FORCE) - -# CMake's InstallRequiredSystemLibraries module searches for a Visual Studio -# installation in order to determine where to copy the required DLLs. This -# installation won't exist when cross-compiling, of course, so silence the -# resulting warnings about missing libraries. -set(CMAKE_INSTALL_SYSTEM_RUNTIME_LIBS_NO_WARNINGS ON) - |