diff options
| author | Florian Hahn <florian.hahn@arm.com> | 2016-12-30 21:28:30 +0000 |
|---|---|---|
| committer | Florian Hahn <florian.hahn@arm.com> | 2016-12-30 21:28:30 +0000 |
| commit | f4ae367c89ce30ee730f566e6b48d17c9acc7c39 (patch) | |
| tree | 22ae1490a35a51c4df4a384ac56add0e4b590c33 | |
| parent | 1efac55b939df40c1a4bcdc0791349ab4637587a (diff) | |
[doc] Clarify steps for contributors without commit access.
Summary: Update the Phabricator docs to clarify how changes are merged for contributors without commit access.
Reviewers: delcypher, aaron.ballman
Subscribers: aaron.ballman, anmol, llvm-commits
Differential Revision: https://reviews.llvm.org/D28184
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@290767 91177308-0d34-0410-b5e6-96231b3b80d8
| -rw-r--r-- | docs/Phabricator.rst | 8 |
1 files changed, 6 insertions, 2 deletions
diff --git a/docs/Phabricator.rst b/docs/Phabricator.rst index 04319a9a378..06a9c6af9b4 100644 --- a/docs/Phabricator.rst +++ b/docs/Phabricator.rst @@ -128,8 +128,12 @@ Committing a change ------------------- Once a patch has been reviewed and approved on Phabricator it can then be -committed to trunk. There are multiple workflows to achieve this. Whichever -method you follow it is recommend that your commit message ends with the line: +committed to trunk. If you do not have commit access, someone has to +commit the change for you (with attribution). It is sufficient to add +a comment to the approved review indicating you cannot commit the patch +yourself. If you have commit access, there are multiple workflows to commit the +change. Whichever method you follow it is recommend that your commit message +ends with the line: :: |