diff options
author | Craig Topper <craig.topper@intel.com> | 2018-07-15 06:52:48 +0000 |
---|---|---|
committer | Craig Topper <craig.topper@intel.com> | 2018-07-15 06:52:48 +0000 |
commit | ecb8905452825ee43c60908e001d34d3c6ff5b40 (patch) | |
tree | 5f8d0e670178be804c511d8e74815f3544b8d972 | |
parent | 9d61922fe7cc1212c4a2252b8bea711f6fea4ec6 (diff) |
[TableGen] Remove what seems to be an unnecessary std::map copy.
The comment says the copy was made so it could be destroyed in the following loop, but the original map wasn't used after the loop.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@337120 91177308-0d34-0410-b5e6-96231b3b80d8
-rw-r--r-- | utils/TableGen/CodeGenDAGPatterns.cpp | 15 |
1 files changed, 6 insertions, 9 deletions
diff --git a/utils/TableGen/CodeGenDAGPatterns.cpp b/utils/TableGen/CodeGenDAGPatterns.cpp index c0ddfeb4f43..19c96fa789b 100644 --- a/utils/TableGen/CodeGenDAGPatterns.cpp +++ b/utils/TableGen/CodeGenDAGPatterns.cpp @@ -3561,10 +3561,7 @@ void CodeGenDAGPatterns::parseInstructionPattern( InstResults.erase(OpName); } - // Loop over the inputs next. Make a copy of InstInputs so we can destroy - // the copy while we're checking the inputs. - std::map<std::string, TreePatternNodePtr> InstInputsCheck(InstInputs); - + // Loop over the inputs next. std::vector<TreePatternNodePtr> ResultNodeOperands; std::vector<Record*> Operands; for (unsigned i = NumResults, e = CGI.Operands.size(); i != e; ++i) { @@ -3573,7 +3570,7 @@ void CodeGenDAGPatterns::parseInstructionPattern( if (OpName.empty()) I.error("Operand #" + Twine(i) + " in operands list has no name!"); - if (!InstInputsCheck.count(OpName)) { + if (!InstInputs.count(OpName)) { // If this is an operand with a DefaultOps set filled in, we can ignore // this. When we codegen it, we will do so as always executed. if (Op.Rec->isSubClassOf("OperandWithDefaultOps")) { @@ -3585,8 +3582,8 @@ void CodeGenDAGPatterns::parseInstructionPattern( I.error("Operand $" + OpName + " does not appear in the instruction pattern"); } - TreePatternNodePtr InVal = InstInputsCheck[OpName]; - InstInputsCheck.erase(OpName); // It occurred, remove from map. + TreePatternNodePtr InVal = InstInputs[OpName]; + InstInputs.erase(OpName); // It occurred, remove from map. if (InVal->isLeaf() && isa<DefInit>(InVal->getLeafValue())) { Record *InRec = static_cast<DefInit*>(InVal->getLeafValue())->getDef(); @@ -3614,8 +3611,8 @@ void CodeGenDAGPatterns::parseInstructionPattern( ResultNodeOperands.push_back(std::move(OpNode)); } - if (!InstInputsCheck.empty()) - I.error("Input operand $" + InstInputsCheck.begin()->first + + if (!InstInputs.empty()) + I.error("Input operand $" + InstInputs.begin()->first + " occurs in pattern but not in operands list!"); TreePatternNodePtr ResultPattern = std::make_shared<TreePatternNode>( |