summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorTobin C. Harding <me@tobin.cc>2018-03-02 08:42:59 +1100
committerTobin C. Harding <me@tobin.cc>2018-04-07 08:50:34 +1000
commit2306a67745ebdf3f98bc954248b74a3f1d57cdc2 (patch)
tree74e40740eb52d3dfc551f5b3f01e29dd6d360068
parent34827374492580b27c3cba29d493dab28c8c25d3 (diff)
leaking_addresses: explicitly name variable used in regex
Currently sub routine may_leak_address() is checking regex against Perl special variable $_ which is _fortunately_ being set correctly in a loop before this sub routine is called. We already have declared a variable to hold this value '$line' we should use it. Use $line in regex match instead of implicit $_ Signed-off-by: Tobin C. Harding <me@tobin.cc>
-rwxr-xr-xscripts/leaking_addresses.pl2
1 files changed, 1 insertions, 1 deletions
diff --git a/scripts/leaking_addresses.pl b/scripts/leaking_addresses.pl
index ce3b9d5a5bbc..ba5f9709bced 100755
--- a/scripts/leaking_addresses.pl
+++ b/scripts/leaking_addresses.pl
@@ -363,7 +363,7 @@ sub may_leak_address
}
$address_re = get_address_re();
- while (/($address_re)/g) {
+ while ($line =~ /($address_re)/g) {
if (!is_false_positive($1)) {
return 1;
}