From 52918c96580e8b428ca36d20e58791688495a110 Mon Sep 17 00:00:00 2001 From: Howard Hinnant Date: Sun, 29 Jul 2012 20:41:19 +0000 Subject: Andrew Morrow: Mainline clang seems to have recently become more strict about the consistent application of visibility attributes, which causes some new breakage in libcxxabi: In file included from src/libcxxabi/src/cxa_default_handlers.cpp:19: src/libcxxabi/src/private_typeinfo.h:123:23: error: visibility does not match previous declaration class __attribute__ ((__visibility__(default))) __class_type_info ^ src/libcxxabi/src/private_typeinfo.h:19:13: note: previous attribute is here #pragma GCC visibility push(hidden) ^ 1 error generated. The forward declaration of __class_type_info is picking up hidden visibility from the #pragma, which conflicts with the default visibility applied when the class is later fully declared. I'm assuming that the full declaration has it right (and that the diagnostic is correct), so the attached patch applies the default visibility attribute to the forward declaration. git-svn-id: https://llvm.org/svn/llvm-project/libcxxabi/trunk@160933 91177308-0d34-0410-b5e6-96231b3b80d8 --- CREDITS.TXT | 4 ++++ 1 file changed, 4 insertions(+) (limited to 'CREDITS.TXT') diff --git a/CREDITS.TXT b/CREDITS.TXT index a99245f..6ed8548 100644 --- a/CREDITS.TXT +++ b/CREDITS.TXT @@ -20,3 +20,7 @@ D: Architect and primary coauthor of libc++abi N: Nick Kledzik E: kledzik@apple.com + +N: Andrew Morrow +E: andrew.c.morrow@gmail.com +D: Minor patches and fixes -- cgit v1.2.3