diff options
| author | Billy Robert O'Neal III <bion@microsoft.com> | 2017-11-21 23:03:02 +0000 |
|---|---|---|
| committer | Billy Robert O'Neal III <bion@microsoft.com> | 2017-11-21 23:03:02 +0000 |
| commit | 9af08238a783f8e4f419f51a1dd483002cafd093 (patch) | |
| tree | 52352a136d5ce9fd1dbeddca354cc2a1480ef02f /test | |
| parent | abba9f214b2d0453ab9a7c1b411d5f31749a3afd (diff) | |
Replace assert(true) in tests with actual asserts. Reviewed as https://reviews.llvm.org/D40324
In a17cd7c641c34b6c4bd4845a4d4fb590cb6c238c Marshall added assert(true) to the vector<bool>::size tests, which break on C1XX:
D:\Contest\gl0qojfu.5pe\src\qa\vc\libs\libcxx\upstream\test\std\containers\sequences\vector.bool\size.pass.cpp(62): error C2220: warning treated as error - no 'object' file generated
d:\contest\gl0qojfu.5pe\src\qa\vc\libs\libcxx\upstream\test\std\containers\sequences\vector.bool\size.pass.cpp(33) : warning C6326: Potential comparison of a constant with another constant.
d:\contest\gl0qojfu.5pe\src\qa\vc\libs\libcxx\upstream\test\std\containers\sequences\vector.bool\size.pass.cpp(52) : warning C6326: Potential comparison of a constant with another constant.
The corresponding test for vector::size asserts assert(c.size() == 3);, so I changed it to do that here.
git-svn-id: https://llvm.org/svn/llvm-project/libcxx/trunk@318812 91177308-0d34-0410-b5e6-96231b3b80d8
Diffstat (limited to 'test')
| -rw-r--r-- | test/std/containers/sequences/vector.bool/size.pass.cpp | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/test/std/containers/sequences/vector.bool/size.pass.cpp b/test/std/containers/sequences/vector.bool/size.pass.cpp index a1dcfd69e..b7cd7ca13 100644 --- a/test/std/containers/sequences/vector.bool/size.pass.cpp +++ b/test/std/containers/sequences/vector.bool/size.pass.cpp @@ -31,7 +31,7 @@ int main() c.push_back(true); assert(c.size() == 2); c.push_back(C::value_type(3)); - assert(true); + assert(c.size() == 3); c.erase(c.begin()); assert(c.size() == 2); c.erase(c.begin()); @@ -50,7 +50,7 @@ int main() c.push_back(true); assert(c.size() == 2); c.push_back(C::value_type(3)); - assert(true); + assert(c.size() == 3); c.erase(c.begin()); assert(c.size() == 2); c.erase(c.begin()); |